Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] ModelPlotsIT.testPartitionFieldWithTerms #30715

Closed
vladimirdolzhenko opened this issue May 18, 2018 · 4 comments · Fixed by #31026
Closed

[CI] ModelPlotsIT.testPartitionFieldWithTerms #30715

vladimirdolzhenko opened this issue May 18, 2018 · 4 comments · Fixed by #31026
Assignees
@dimitris-athanasiou
Labels
:ml Machine learning >test-failure Triaged test failures from CI v6.4.0

Comments

@vladimirdolzhenko
Copy link
Contributor

Log:

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=opensuse/1066/console

  2> REPRODUCE WITH: ./gradlew :x-pack:qa:ml-native-tests:integTestRunner -Dtests.seed=7B45534D9707C727 -Dtests.class=org.elasticsearch.xpack.ml.integration.ModelPlotsIT -Dtests.method="testPartitionFieldWithTerms" -Dtests.security.manager=true -Dtests.locale=en-PH -Dtests.timezone=Antarctica/Palmer
   > Throwable #1: java.lang.AssertionError: 
   > Expected: <23>
   >      but: was <24>
   >   at __randomizedtesting.SeedInfo.seed([7B45534D9707C727:3650B455272ED35]:0)
   >   at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
   >   at org.elasticsearch.xpack.ml.integration.ModelPlotsIT.testPartitionFieldWithTerms(ModelPlotsIT.java:104)
   >   at java.lang.Thread.run(Thread.java:748)

@elastic/ml-core could you please have a look ?
@vladimirdolzhenko vladimirdolzhenko added >test-failure Triaged test failures from CI :ml Machine learning v6.4.0 labels May 18, 2018
@dimitris-athanasiou dimitris-athanasiou self-assigned this May 18, 2018
@dimitris-athanasiou dimitris-athanasiou mentioned this issue May 18, 2018
Merged
dimitris-athanasiou added a commit that referenced this issue May 18, 2018
@dimitris-athanasiou
[ML][TEST] Fix bucket count assertion in ModelPlotsIT (#30717)
6bb2a1d 
As the first record is random, there's a chance it will
be aligned on a bucket start. Thus we need to check the
bucket count is in [23, 24].

Closes #30715
dimitris-athanasiou added a commit that referenced this issue May 18, 2018
@dimitris-athanasiou
[ML][TEST] Fix bucket count assertion in ModelPlotsIT (#30717)
4ca5e3f 
As the first record is random, there's a chance it will
be aligned on a bucket start. Thus we need to check the
bucket count is in [23, 24].

Closes #30715
dimitris-athanasiou added a commit that referenced this issue May 18, 2018
@dimitris-athanasiou
[ML][TEST] Fix bucket count assertion in ModelPlotsIT (#30717)
de57417 
As the first record is random, there's a chance it will
be aligned on a bucket start. Thus we need to check the
bucket count is in [23, 24].

Closes #30715
@vladimirdolzhenko
Copy link
Contributor Author

awesome job @dimitris-athanasiou 👍

@ywelsch
Copy link
Contributor

ywelsch commented Jun 1, 2018

This is still failing with same issue:

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=amazon/1094/console

@ywelsch ywelsch reopened this Jun 1, 2018
@droberts195
Copy link
Contributor

@dimitris-athanasiou please could you take a look at the model plot issue? When you look at the log you'll see it's full of errors like this:

[2018-06-01T07:58:25,084][ERROR][o.e.x.m.j.p.l.CppLogMessageHandler] [lookback-job] [autodetect/123361] [CMonotonicTime.cc@40] Failed to get reading from hi-res clock

I suspect these are completely unrelated to the problem logged in this issue, but a side effect of the recent seccomp changes in the C++. I have asked @davidkyle to look into the hi-res clock failures as part of the ml-cpp seccomp work.

@dimitris-athanasiou
Copy link
Contributor

@droberts195 I missed relaxing the assertion for one of the tests in #30717. I'll raise a PR fixing that shortly.

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Jun 1, 2018
@dimitris-athanasiou
[ML][TEST] Fix bucket count assertion in all tests in ModelPlotsIT
2ce03e2 
This fixes the last remaining test that was missed in elastic#30717.

Closes elastic#30715
@dimitris-athanasiou dimitris-athanasiou mentioned this issue Jun 1, 2018
Merged
dimitris-athanasiou added a commit that referenced this issue Jun 1, 2018
@dimitris-athanasiou
[ML][TEST] Fix bucket count assertion in all tests in ModelPlotsIT (#…
9141108 
…31026)

This fixes the last remaining test that was missed in #30717.

Closes #30715
dimitris-athanasiou added a commit that referenced this issue Jun 1, 2018
@dimitris-athanasiou
[ML][TEST] Fix bucket count assertion in all tests in ModelPlotsIT (#…
f76ce43 
…31026)

This fixes the last remaining test that was missed in #30717.

Closes #30715
dimitris-athanasiou added a commit that referenced this issue Jun 1, 2018
@dimitris-athanasiou
[ML][TEST] Fix bucket count assertion in all tests in ModelPlotsIT (#…
0794d4a 
…31026)

This fixes the last remaining test that was missed in #30717.

Closes #30715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimitris-athanasiou dimitris-athanasiou

Labels
:ml Machine learning >test-failure Triaged test failures from CI v6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML][TEST] Fix bucket count assertion in all tests in ModelPlotsIT dimitris-athanasiou/elasticsearch
4 participants
@vladimirdolzhenko @ywelsch @droberts195 @dimitris-athanasiou