Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VersionUtilsTests.testGradleVersionsMatchVersionUtils fails on 6.x intake #30133

Closed
mayya-sharipova opened this issue Apr 25, 2018 · 4 comments · Fixed by #30322
Closed

VersionUtilsTests.testGradleVersionsMatchVersionUtils fails on 6.x intake #30133

mayya-sharipova opened this issue Apr 25, 2018 · 4 comments · Fixed by #30322
Assignees
@hub-cap
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test-failure Triaged test failures from CI

Comments

@mayya-sharipova
Copy link
Contributor

5 failures within 24 hours

The most recent CI failures:

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/1608/console
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/1606/console

Reproduction line:
./gradlew :test:framework:test -Dtests.seed=AD2D0BA6D0112AF0 -Dtests.class=org.elasticsearch.test.VersionUtilsTests -Dtests.method="testGradleVersionsMatchVersionUtils" -Dtests.security.manager=true -Dtests.locale=fr-LU -Dtests.timezone=America/St_Thomas

It seems that 5.6.10 in not included in bwcVersions.wireCompatible versions:

FAILURE 0.18s | VersionUtilsTests.testGradleVersionsMatchVersionUtils <<< FAILURES!

Throwable #1: java.lang.AssertionError: expected:<[5.0.0, 5.0.1, 5.0.2, 5.1.1, 5.1.2, 5.2.0, 5.2.1, 5.2.2, 5.3.0, 5.3.1, 5.3.2, 5.3.3, 5.4.0, 5.4.1, 5.4.2, 5.4.3, 5.5.0, 5.5.1, 5.5.2, 5.5.3, 5.6.0, 5.6.1, 5.6.2, 5.6.3, 5.6.4, 5.6.5, 5.6.6, 5.6.7, 5.6.8, 5.6.9, 5.6.10, 6.0.0, 6.0.1, 6.1.0, 6.1.1, 6.1.2, 6.1.3, 6.1.4, 6.2.0, 6.2.1, 6.2.2, 6.2.3, 6.2.4]> but was:<[5.0.0, 5.0.1, 5.0.2, 5.1.1, 5.1.2, 5.2.0, 5.2.1, 5.2.2, 5.3.0, 5.3.1, 5.3.2, 5.3.3, 5.4.0, 5.4.1, 5.4.2, 5.4.3, 5.5.0, 5.5.1, 5.5.2, 5.5.3, 5.6.0, 5.6.1, 5.6.2, 5.6.3, 5.6.4, 5.6.5, 5.6.6, 5.6.7, 5.6.8, 5.6.9, 6.0.0, 6.0.1, 6.1.0, 6.1.1, 6.1.2, 6.1.3, 6.1.4, 6.2.0, 6.2.1, 6.2.2, 6.2.3, 6.2.4]>
at __randomizedtesting.SeedInfo.seed([AD2D0BA6D0112AF0:78EE11A31D01673E]:0)
at org.elasticsearch.test.VersionUtilsTests.testGradleVersionsMatchVersionUtils(VersionUtilsTests.java:319)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:564)
at java.base/java.lang.Thread.run(Thread.java:844)
@mayya-sharipova mayya-sharipova assigned hub-cap and unassigned hub-cap Apr 25, 2018
@mayya-sharipova mayya-sharipova added the :Delivery/Build Build or test infrastructure label Apr 25, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@mayya-sharipova mayya-sharipova added the >test-failure Triaged test failures from CI label Apr 25, 2018
@mayya-sharipova
Copy link
Contributor Author

For now, silencing this test in 6.x:

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/30133")
public void testGradleVersionsMatchVersionUtils() {

@nik9000 nik9000 self-assigned this Apr 25, 2018
@nik9000
Copy link
Member

nik9000 commented Apr 25, 2018

I'll have a look!

@nik9000 nik9000 assigned hub-cap and unassigned nik9000 Apr 25, 2018
@nik9000
Copy link
Member

nik9000 commented Apr 25, 2018

@hub-cap will do it instead.

hub-cap added a commit to hub-cap/elasticsearch that referenced this issue May 1, 2018
@hub-cap
Align logic in VersionUtils to VersionCollection
a8f5da4 
The BCW generation code in VersionCollection.groovy was updated a while
ago to accurately grab released and unreleased versions from
Version.java. The logic for VersionUtils, which is the java equivalent
of VersionCollection, was never updated to fix the bugs present in
VersionCollection. This commit uses the same logic present in
VersionCollection in VersionUtils. While the best solution is not to
duplicate logic, this commit will first fix the test, and de duping the
logic is out of scope for this.

Relates elastic#30133
@hub-cap hub-cap mentioned this issue May 1, 2018
Closed
rjernst added a commit to rjernst/elasticsearch that referenced this issue May 2, 2018
@rjernst
Tests: Simplify VersionUtils released version splitting
b90e848 
This commit refactors VersionUtils.resolveReleasedVersions to be
simpler, and in the process fixes the behavior to match that of
VersionCollection.groovy.

closes elastic#30133
@rjernst rjernst mentioned this issue May 2, 2018
Merged
rjernst added a commit that referenced this issue May 2, 2018
@rjernst
Tests: Simplify VersionUtils released version splitting (#30322)
f0e9267 
This commit refactors VersionUtils.resolveReleasedVersions to be
simpler, and in the process fixes the behavior to match that of
VersionCollection.groovy.

closes #30133
rjernst added a commit that referenced this issue May 2, 2018
@rjernst
Tests: Simplify VersionUtils released version splitting (#30322)
b4abdc5 
This commit refactors VersionUtils.resolveReleasedVersions to be
simpler, and in the process fixes the behavior to match that of
VersionCollection.groovy.

closes #30133
rjernst added a commit that referenced this issue May 2, 2018
@rjernst
Tests: Simplify VersionUtils released version splitting (#30322)
6f29c73 
This commit refactors VersionUtils.resolveReleasedVersions to be
simpler, and in the process fixes the behavior to match that of
VersionCollection.groovy.

closes #30133
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hub-cap hub-cap

Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests: Simplify VersionUtils released version splitting rjernst/elasticsearch
5 participants
@nik9000 @hub-cap @mark-vieira @mayya-sharipova @elasticmachine