Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query.sort should be an array, not an object #30

Closed
clintongormley opened this issue Feb 19, 2010 · 4 comments
Closed

query.sort should be an array, not an object #30

clintongormley opened this issue Feb 19, 2010 · 4 comments

Comments

@clintongormley
Copy link
Contributor

Because JSON doesn't take order into account, sort should be an array, not an object.

For instance:
sort : {
postDate : {reverse : true},
user : { },
score : { }
}

is the equivalent of:

sort : {
    score : { }
    user : { },
    postDate : {reverse : true},
}

Instead, perhaps this syntax:

sort : [
    "score",
    "user",
    { "postDate": { "reverse": true}} 
]

clint

@kimchy
Copy link
Member

kimchy commented Feb 20, 2010

Have you seem somewhere that JSON doesn't take order into account? All the parsers that I have seen, for example, do create a linked hash map to represent an object, which means order is maintained. Of course, I don't convert the JSON into "nodes" or maps, but use pull parsing instead, but I still take order into account.

In any case, I agree that the format you mentioned is more coherent. I will add support for that (and the old format as well :) ).

@kimchy
Copy link
Member

kimchy commented Feb 20, 2010

Allow for the sort search element to speciy the sort fields in an array, closed by 1aa8e01.

@clintongormley
Copy link
Contributor Author

To be honest, no I hadn't - but I've found this post which discusses the issue http://pmuellr.blogspot.com/2009/04/ordered-javascript-properties.html.

In Perl, hashes (the equivalent structure) are unordered, so I'm glad you're happy to add support for the array form :)

@clintongormley
Copy link
Contributor Author

Excellent - I can confirm that this is working

dadoonet pushed a commit that referenced this issue Jun 5, 2015
If the AWS client throws an exception (e.g: because of a DNS failure) it will end up killing the rejoin thread and stop retrying which can lead to a node getting stuck unable to rejoin the cluster.

Closes #30.
dadoonet added a commit that referenced this issue Jun 5, 2015
Closes #30.
(cherry picked from commit bf7cc95)
dadoonet added a commit that referenced this issue Jun 5, 2015
Closes #30.

(cherry picked from commit fad6ebf)
dadoonet pushed a commit that referenced this issue Jun 5, 2015
johtani added a commit that referenced this issue Jun 5, 2015
dadoonet added a commit that referenced this issue Jun 5, 2015
Related to #30

(cherry picked from commit 442d06e)
(cherry picked from commit aa27eb9)
tlrx added a commit that referenced this issue Jun 9, 2015
ywelsch pushed a commit to ywelsch/elasticsearch that referenced this issue Apr 24, 2018
Previously, we tracked any active publication, and associated timeout, using the
PUBLISH_IN_PROGRESS leader mode.

This change introduces a separate timeout for publication and tracks it using
the FutureExecutor instead.
ClaudioMFreitas pushed a commit to ClaudioMFreitas/elasticsearch-1 that referenced this issue Nov 12, 2019
Added functionality to copy elasticsearch scripts
henningandersen pushed a commit to henningandersen/elasticsearch that referenced this issue Jun 4, 2020
* Added parameter for addressing frozen indices

* Added frozen challenges

* Increased generated data volume and reduces data volume queried

* Added pre_filter_shard_size parameter to Kibana queries when querying frozen indices

* Corrected query string config

* Corrected fieldstats runner

* Corrected kibana runner

* Added debug parameter for kibana simulation

* Added debug parameter for kibana simulation

* Added IP filter to dashboards to make queries lighter

* Altered format of debug output

* Added frozen status to debug output

* Moved frozen handling to parameter source query generation

* Made frozen querying lighter

* Enable fieldstats runner to handle frozen indices

* Modified frozen querying parameters and added ability to use track parameters

* Cleaned up code and docs
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Oct 2, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants