Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded elements from ranking evaluation queries #29674

Closed
cbuescher opened this issue Apr 24, 2018 · 1 comment
Closed

Remove unneeded elements from ranking evaluation queries #29674

cbuescher opened this issue Apr 24, 2018 · 1 comment
Assignees
@cbuescher
Labels
>enhancement :Search Relevance/Ranking Scoring, rescoring, rank evaluation. Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch

Comments

@cbuescher
Copy link
Member

Currently the ranking evaluation API accepts the full query syntax for the queries specified in the test set and executes them as a multi search. This potentially runs costly aggregations and suggestions too. Since I think aggregations, suggestions and highlighting don't play a role in search evaluation, we ignore and remove those parts of the query if they get accidentally added in order to reduce its cost.
I'm not sure yet if it would be better to throw an error in these cases or just silently ignore the parts
that are irrelevent in the context of this API.
@colings86 colings86 added >enhancement :Search Relevance/Ranking Scoring, rescoring, rank evaluation. labels Apr 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@cbuescher cbuescher mentioned this issue Apr 25, 2018
Merged
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Apr 26, 2018
Forbid expensive query parts in ranking evaluation
6084785 
Currently the ranking evaluation API accepts the full query syntax for
the queries specified in the evaluation set and executes them via multi
search. This potentially runs costly aggregations and suggestions too.
This change adds checks that forbid using aggregations, suggesters or
highlighters in the queries that are run as part of the ranking
evaluation since they are irrelevent in the context of this API.

Closes elastic#29674
@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbuescher cbuescher

Labels
>enhancement :Search Relevance/Ranking Scoring, rescoring, rank evaluation. Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@colings86 @javanna @cbuescher @elasticmachine