Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract XContent from the elasticsearch server #28504

Closed
4 tasks done
nik9000 opened this issue Feb 2, 2018 · 4 comments
Closed
4 tasks done

Extract XContent from the elasticsearch server #28504

nik9000 opened this issue Feb 2, 2018 · 4 comments
Assignees
@dakrone @nik9000
Labels
v6.3.0 v7.0.0-beta1

Comments

@nik9000
Copy link
Member

nik9000 commented Feb 2, 2018 •
edited by dakrone
Loading

One day we'd like the high level rest client not to depend on Elasticsearch's server code. As a first step we're going to extract Elasticsearch's xcontent classes into a jar without dependencies.

  • Replace xcontent's explicit dependencies on Log4J with something pluggable and have the Elasticsearch server plug Log4J into it (@dakrone)
  • Separate xcontent from Lucene (@dakrone)
  • Separate xcontent from other parts of Elasticsearch (like commons) (@dakrone)
  • Build the jar
@nik9000
Copy link
Member Author

nik9000 commented Feb 2, 2018

#28449 and #28488 started this process. It'll take a few more PRs to finish it.

@nik9000
Copy link
Member Author

nik9000 commented Feb 2, 2018

As is #28503.

dakrone added a commit to dakrone/elasticsearch that referenced this issue Feb 5, 2018
@dakrone
Replace more deprecated ParseField.match calls with non-deprecated call
97ffb92 
This replaces more of the `ParseField.match` calls with the same call using a
deprecation handler.

Relates to elastic#28504
@dakrone dakrone mentioned this issue Feb 5, 2018
Merged
dakrone added a commit to dakrone/elasticsearch that referenced this issue Feb 5, 2018
@dakrone
Switch to non-deprecated ParseField.match method for o.e.search
cfbc0d7 
This replaces more of the `ParseField.match` calls with the same call using a
deprecation handler. It encapsulates all of the instances in the
`org.elastsicsearch.search` package.

Relates to elastic#28504
@dakrone dakrone mentioned this issue Feb 5, 2018
Merged
dakrone added a commit that referenced this issue Feb 8, 2018
@dakrone
Replace more deprecated ParseField.match calls with non-deprecated ca…
b64bf51 
…ll (#28525)

* Replace more deprecated ParseField.match calls with non-deprecated call

This replaces more of the `ParseField.match` calls with the same call using a
deprecation handler.

Relates to #28504

* Address Nik's comments
dakrone added a commit that referenced this issue Feb 8, 2018
@dakrone
Replace more deprecated ParseField.match calls with non-deprecated ca…
f3df274 
…ll (#28525)

* Replace more deprecated ParseField.match calls with non-deprecated call

This replaces more of the `ParseField.match` calls with the same call using a
deprecation handler.

Relates to #28504

* Address Nik's comments
dakrone added a commit that referenced this issue Feb 8, 2018
@dakrone
Switch to non-deprecated ParseField.match method for o.e.search (#28526)
2e4c834 
* Switch to non-deprecated ParseField.match method for o.e.search

This replaces more of the `ParseField.match` calls with the same call using a
deprecation handler. It encapsulates all of the instances in the
`org.elastsicsearch.search` package.

Relates to #28504

* Address Nik's comments
dakrone added a commit that referenced this issue Feb 8, 2018
@dakrone
Switch to non-deprecated ParseField.match method for o.e.search (#28526)
bd7e5ee 
* Switch to non-deprecated ParseField.match method for o.e.search

This replaces more of the `ParseField.match` calls with the same call using a
deprecation handler. It encapsulates all of the instances in the
`org.elastsicsearch.search` package.

Relates to #28504

* Address Nik's comments
dakrone added a commit to dakrone/elasticsearch that referenced this issue Feb 8, 2018
@dakrone
Remove all instances of the deprecated ParseField.match method
6bca790 
This removes all the server references to the deprecated `ParseField.match`
method in favor of the method that passes in the deprecation logger.

Relates to elastic#28504
@dakrone dakrone mentioned this issue Feb 8, 2018
Merged
dakrone added a commit that referenced this issue Feb 9, 2018
@dakrone
Remove all instances of the deprecated ParseField.match method (#28586
5263b8c 
)

This removes all the server references to the deprecated `ParseField.match`
method in favor of the method that passes in the deprecation logger.

Relates to #28504
dakrone added a commit that referenced this issue Feb 9, 2018
@dakrone
Remove all instances of the deprecated ParseField.match method (#28586
90f26c2 
)

This removes all the server references to the deprecated `ParseField.match`
method in favor of the method that passes in the deprecation logger.

Relates to #28504
dakrone added a commit to dakrone/elasticsearch that referenced this issue Feb 9, 2018
@dakrone
Switch to hardcoding Smile as the state format
8cf1a23 
This commit changes the state format that was previously passed in to
`MetaDataStateFormat` to always use Smile. This doesn't actually change the
format, since we have used Smile for writing the format since at least 5.0. This
removes the automatic detection of the state format when reading state, since
any state that could be processed in 6.x and 7.x would already have been written
in Smile format.

This is work towards removing the deprecated methods in the XContent code where
we do automatic content-type detection.

Relates to elastic#28504
@dakrone dakrone mentioned this issue Feb 9, 2018
Merged
dakrone added a commit that referenced this issue Feb 12, 2018
@dakrone
Switch to hardcoding Smile as the state format (#28610)
6538542 
This commit changes the state format that was previously passed in to
`MetaDataStateFormat` to always use Smile. This doesn't actually change the
format, since we have used Smile for writing the format since at least 5.0. This
removes the automatic detection of the state format when reading state, since
any state that could be processed in 6.x and 7.x would already have been written
in Smile format.

This is work towards removing the deprecated methods in the XContent code where
we do automatic content-type detection.

Relates to #28504
dakrone added a commit that referenced this issue Feb 12, 2018
@dakrone
Switch to hardcoding Smile as the state format (#28610)
0a9c03e 
This commit changes the state format that was previously passed in to
`MetaDataStateFormat` to always use Smile. This doesn't actually change the
format, since we have used Smile for writing the format since at least 5.0. This
removes the automatic detection of the state format when reading state, since
any state that could be processed in 6.x and 7.x would already have been written
in Smile format.

This is work towards removing the deprecated methods in the XContent code where
we do automatic content-type detection.

Relates to #28504
dakrone added a commit to dakrone/elasticsearch that referenced this issue Feb 12, 2018
@dakrone
Add XContentHelper shims for move to specifying deprecation logger
504b2d4 
This adds deprecated shims for the `convertToMap` method in `XContentHelper`.
These shims will be removed once all callers switch to passing in the
`DeprecationHandler` when converting to a map.

Relates to elastic#28504
@dakrone dakrone mentioned this issue Feb 12, 2018
Closed
dakrone added a commit to dakrone/elasticsearch that referenced this issue Feb 13, 2018
@dakrone
Move more XContent.createParser calls to non-deprecated version
cb43bb3 
This moves more of the callers to pass in the DeprecationHandler.

Relates to elastic#28504
@dakrone dakrone mentioned this issue Feb 13, 2018
Merged
dakrone added a commit to dakrone/elasticsearch that referenced this issue Feb 13, 2018
@dakrone
Move more XContent.createParser calls to non-deprecated version
cb81b4b 
Part 2

This moves more of the callers to pass in the DeprecationHandler.

Relates to elastic#28504
@dakrone dakrone mentioned this issue Feb 13, 2018
Merged
dakrone added a commit that referenced this issue Apr 2, 2018
@dakrone
Begin moving XContent to a separate lib/artifact (#29300)
6b2167f 
* Begin moving XContent to a separate lib/artifact

This commit moves a large portion of the XContent code from the `server` project
to the `libs/xcontent` project. For the pieces that have been moved, some
helpers have been duplicated to allow them to be decoupled from ES helper
classes. In addition, `Booleans` and `CheckedFunction` have been moved to the
`elasticsearch-core`  project.

This decoupling is a move so that we can eventually make things like the
high-level REST client not rely on the entire ES jar, only the parts it needs.

There are some pieces that are still not decoupled, in particular some of the
XContent tests still remain in the server project, this is because they test a
large portion of the pluggable xcontent pieces through
`XContentElasticsearchException`. They may be decoupled in future work.
Additionally, there may be more piecese that we want to move to the xcontent lib
in the future that are not part of this PR, this is a starting point.

Relates to #28504
dakrone added a commit that referenced this issue Apr 2, 2018
@dakrone
Begin moving XContent to a separate lib/artifact (#29300)
ef6097f 
* Begin moving XContent to a separate lib/artifact

This commit moves a large portion of the XContent code from the `server` project
to the `libs/xcontent` project. For the pieces that have been moved, some
helpers have been duplicated to allow them to be decoupled from ES helper
classes. In addition, `Booleans` and `CheckedFunction` have been moved to the
`elasticsearch-core`  project.

This decoupling is a move so that we can eventually make things like the
high-level REST client not rely on the entire ES jar, only the parts it needs.

There are some pieces that are still not decoupled, in particular some of the
XContent tests still remain in the server project, this is because they test a
large portion of the pluggable xcontent pieces through
`XContentElasticsearchException`. They may be decoupled in future work.
Additionally, there may be more piecese that we want to move to the xcontent lib
in the future that are not part of this PR, this is a starting point.

Relates to #28504
dakrone added a commit to dakrone/elasticsearch that referenced this issue Apr 4, 2018
@dakrone
Move ObjectParser into the x-content lib
0939078 
This moves `ObjectParser`, `AbstractObjectParser`, and
`ConstructingObjectParser` into the libs/x-content dependency. This decoupling
allows them to be used for parsing for projects that don't want to depend on the
entire Elasticsearch jar.

Relates to elastic#28504
@dakrone dakrone mentioned this issue Apr 4, 2018
Merged
dakrone added a commit to dakrone/elasticsearch that referenced this issue Apr 4, 2018
@dakrone
Move Tuple into elasticsearch-core
26e1ad9 
This allows us to use Tuple from other projects that don't want to rely on the
entire Elasticsearch jar.

I have also added very simple tests, since there were none.

Relates tangentially to elastic#28504
@dakrone dakrone mentioned this issue Apr 4, 2018
Merged
dakrone added a commit that referenced this issue Apr 6, 2018
@dakrone
Move Tuple into elasticsearch-core (#29375)
160d25f 
* Move Tuple into elasticsearch-core

This allows us to use Tuple from other projects that don't want to rely on the
entire Elasticsearch jar.

I have also added very simple tests, since there were none.

Relates tangentially to #28504
dakrone added a commit that referenced this issue Apr 6, 2018
@dakrone
Move Tuple into elasticsearch-core (#29375)
7de5814 
* Move Tuple into elasticsearch-core

This allows us to use Tuple from other projects that don't want to rely on the
entire Elasticsearch jar.

I have also added very simple tests, since there were none.

Relates tangentially to #28504
dakrone added a commit that referenced this issue Apr 6, 2018
@dakrone
Move ObjectParser into the x-content lib (#29373)
a93c942 
* Move ObjectParser into the x-content lib

This moves `ObjectParser`, `AbstractObjectParser`, and
`ConstructingObjectParser` into the libs/x-content dependency. This decoupling
allows them to be used for parsing for projects that don't want to depend on the
entire Elasticsearch jar.

Relates to #28504
dakrone added a commit that referenced this issue Apr 6, 2018
@dakrone
Move ObjectParser into the x-content lib (#29373)
37eb2b1 
* Move ObjectParser into the x-content lib

This moves `ObjectParser`, `AbstractObjectParser`, and
`ConstructingObjectParser` into the libs/x-content dependency. This decoupling
allows them to be used for parsing for projects that don't want to depend on the
entire Elasticsearch jar.

Relates to #28504
dakrone added a commit to dakrone/elasticsearch that referenced this issue Apr 9, 2018
@dakrone
Remove custom PeriodType formatting from TimeValue
2376309 
In order to decouple TimeValue from Joda, this removes the unused `format`
methods.

Relates to elastic#28504
@dakrone dakrone mentioned this issue Apr 9, 2018
Merged
dakrone added a commit that referenced this issue Apr 10, 2018
@dakrone
Remove custom PeriodType formatting from TimeValue (#29433)
0f40199 
In order to decouple TimeValue from Joda, this removes the unused `format`
methods.

Relates to #28504
dakrone added a commit that referenced this issue Apr 10, 2018
@dakrone
Remove custom PeriodType formatting from TimeValue (#29433)
04a85db 
In order to decouple TimeValue from Joda, this removes the unused `format`
methods.

Relates to #28504
dakrone added a commit to dakrone/elasticsearch that referenced this issue Apr 10, 2018
@dakrone
Decouple TimeValue from Elasticsearch server classes
abcd4f5 
This commit decouples the `TimeValue` class from the other server classes. This
is in preperation to move `TimeValue` into the `elasticsearch-core` jar,
allowing us to use it from projects that cannot depend on the elasticsearch-core
library.

Relates to elastic#28504
@dakrone dakrone mentioned this issue Apr 10, 2018
Merged
dakrone added a commit that referenced this issue Apr 11, 2018
@dakrone
Decouple TimeValue from Elasticsearch server classes (#29454)
263349f 
* Decouple TimeValue from Elasticsearch server classes

This commit decouples the `TimeValue` class from the other server classes. This
is in preperation to move `TimeValue` into the `elasticsearch-core` jar,
allowing us to use it from projects that cannot depend on the elasticsearch-core
library.

Relates to #28504
dakrone added a commit that referenced this issue Apr 11, 2018
@dakrone
Decouple TimeValue from Elasticsearch server classes (#29454)
1690178 
* Decouple TimeValue from Elasticsearch server classes

This commit decouples the `TimeValue` class from the other server classes. This
is in preperation to move `TimeValue` into the `elasticsearch-core` jar,
allowing us to use it from projects that cannot depend on the elasticsearch-core
library.

Relates to #28504
dakrone added a commit to dakrone/elasticsearch that referenced this issue Apr 11, 2018
@dakrone
Move TimeValue into elasticsearch-core project
fa47e9c 
This commit moves the `TimeValue` class into the elasticsearch-core project.
This allows us to use this class in many of our other projects without relying
on the entire `server` jar.

Relates to elastic#28504
@dakrone dakrone mentioned this issue Apr 11, 2018
Merged
dakrone added a commit that referenced this issue Apr 12, 2018
@dakrone
Move TimeValue into elasticsearch-core project (#29486)
1409735 
This commit moves the `TimeValue` class into the elasticsearch-core project.
This allows us to use this class in many of our other projects without relying
on the entire `server` jar.

Relates to #28504
dakrone added a commit that referenced this issue Apr 12, 2018
@dakrone
Move TimeValue into elasticsearch-core project (#29486)
0935250 
This commit moves the `TimeValue` class into the elasticsearch-core project.
This allows us to use this class in many of our other projects without relying
on the entire `server` jar.

Relates to #28504
@dakrone
Copy link
Member

dakrone commented Apr 20, 2018

All the currently relevant parts of XContent have been moved into the new x-content artifact, so I'm going to consider this resolved for now.

@dakrone dakrone closed this as completed Apr 20, 2018
@marco-miller marco-miller mentioned this issue May 22, 2018
Closed
@nomoa nomoa mentioned this issue Jun 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakrone dakrone

@nik9000 nik9000

Labels
v6.3.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dakrone @nik9000 @colings86