Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] CoreFullClusterRestartIT testRecovery fails to find old segments #27649

Closed
bleskes opened this issue Dec 4, 2017 · 1 comment
Closed

[CI] CoreFullClusterRestartIT testRecovery fails to find old segments #27649

bleskes opened this issue Dec 4, 2017 · 1 comment
Assignees
@bleskes
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@bleskes
Copy link
Contributor

bleskes commented Dec 4, 2017

see https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+oracle-periodic/1556/console

REPRODUCE WITH: gradle :qa:full-cluster-restart:v6.1.0-SNAPSHOT#upgradedClusterTestRunner \
  -Dtests.seed=BA8111C3B9EB2432 \
  -Dtests.class=org.elasticsearch.upgrades.FullClusterRestartIT \
  -Dtests.method="testRecovery" \
  -Dtests.security.manager=true \
  -Dtests.locale=es-VE \
  -Dtests.timezone=MET

java.lang.AssertionError: expected at least 1 old segment. Actual: 0
	at __randomizedtesting.SeedInfo.seed([BA8111C3B9EB2432:7B71686F94BBEE95]:0)
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failEquals(Assert.java:185)
	at org.junit.Assert.assertNotEquals(Assert.java:199)
	at org.elasticsearch.upgrades.FullClusterRestartIT.testRecovery(FullClusterRestartIT.java:697)
@bleskes bleskes added the :Delivery/Build Build or test infrastructure label Dec 4, 2017
@bleskes bleskes self-assigned this Dec 4, 2017
dakrone added a commit that referenced this issue Dec 4, 2017
@dakrone
[TEST] Add AwaitsFix for FullClusterRestartIT.testRecovery
d3721c4 
See: #27649
bleskes added a commit that referenced this issue Dec 5, 2017
@bleskes
IndexShard - only flush on primary activation if it's a relocation ta…
a16d5c5 
…rget from an old node

#27580 added extra flushes when a shard transitions to primary to make sure that we never replay translog ops without seq# during recovery. The current logic causes an extra flush when a primary starts when it's recovering from the store. This is not needed as we also flush in the engine itself (to add sequence numbers info into the commit). This double flushing confuses tests and is unneeded.

Fixes #27649
bleskes added a commit that referenced this issue Dec 5, 2017
@bleskes
IndexShard - only flush on primary activation if it's a relocation ta…
e8c34c2 
…rget from an old node

#27580 added extra flushes when a shard transitions to primary to make sure that we never replay translog ops without seq# during recovery. The current logic causes an extra flush when a primary starts when it's recovering from the store. This is not needed as we also flush in the engine itself (to add sequence numbers info into the commit). This double flushing confuses tests and is unneeded.

Fixes #27649
bleskes added a commit that referenced this issue Dec 5, 2017
@bleskes
IndexShard - only flush on primary activation if it's a relocation ta…
9ba66d8 
…rget from an old node

#27580 added extra flushes when a shard transitions to primary to make sure that we never replay translog ops without seq# during recovery. The current logic causes an extra flush when a primary starts when it's recovering from the store. This is not needed as we also flush in the engine itself (to add sequence numbers info into the commit). This double flushing confuses tests and is unneeded.

Fixes #27649

# Conflicts:
#	core/src/main/java/org/elasticsearch/index/shard/IndexShard.java
@bleskes
Copy link
Contributor Author

bleskes commented Dec 6, 2017

This has been resolved.

@bleskes bleskes closed this as completed Dec 6, 2017
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bleskes bleskes

Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bleskes @mark-vieira