Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a soft limit on the number of requested doc-value and script fields #26390

Closed
jpountz opened this issue Aug 25, 2017 · 1 comment
Closed

Add a soft limit on the number of requested doc-value and script fields #26390

jpountz opened this issue Aug 25, 2017 · 1 comment
Assignees
@cbuescher
Labels
>enhancement help wanted adoptme :Search/Search Search-related issues that do not fall into other categories

Comments

@jpountz
Copy link
Contributor

jpountz commented Aug 25, 2017

Spin-off from #26299. Doc-value and script fields are costly since they might incur a per-field per-document seek, while stored fields only incur a per-document seek. So we should add a soft limit over the number of requested doc-value and script fields.
@jpountz jpountz added :Search/Search Search-related issues that do not fall into other categories help wanted adoptme >enhancement labels Aug 25, 2017
@jpountz jpountz mentioned this issue Aug 25, 2017
Closed
@clintongormley clintongormley mentioned this issue Aug 25, 2017
Closed
24 tasks
@cbuescher cbuescher self-assigned this Aug 28, 2017
@cbuescher cbuescher mentioned this issue Sep 11, 2017
Merged
cbuescher added a commit to cbuescher/elasticsearch that referenced this issue Sep 11, 2017
@cbuescher
Add a soft limit for the number of requested doc-value fields
3ad15f1 
Requesting to many docvalue_fields in a search request can potentially be costly
because it might incur a per-field per-document seek. This change introduces a
soft limit on the number of fields that can be retrieved. The setting can be
changed per index using the `index.max_docvalue_fields_search` setting.

Relates to elastic#26390
@cbuescher cbuescher mentioned this issue Sep 12, 2017
Merged
cbuescher added a commit that referenced this issue Sep 13, 2017
@cbuescher
Add a soft limit for the number of requested doc-value fields (#26574)
e00db23 
Requesting to many docvalue_fields in a search request can potentially be costly
because it might incur a per-field per-document seek. This change introduces a
soft limit on the number of fields that can be retrieved. The setting can be
changed per index using the `index.max_docvalue_fields_search` setting.

Relates to #26390
cbuescher added a commit that referenced this issue Sep 13, 2017
@cbuescher
Add a soft limit for the number of requested doc-value fields (#26574)
4a2d431 
Requesting to many docvalue_fields in a search request can potentially be costly
because it might incur a per-field per-document seek. This change introduces a
soft limit on the number of fields that can be retrieved. The setting can be
changed per index using the `index.max_docvalue_fields_search` setting.

Relates to #26390
cbuescher added a commit that referenced this issue Sep 13, 2017
@cbuescher
Add a soft limit for the number of requested doc-value fields (#26574)
9a98f07 
Requesting to many docvalue_fields in a search request can potentially be costly
because it might incur a per-field per-document seek. This change introduces a
soft limit on the number of fields that can be retrieved. The setting can be
changed per index using the `index.max_docvalue_fields_search` setting.

Relates to #26390
cbuescher added a commit to cbuescher/elasticsearch that referenced this issue Sep 13, 2017
@cbuescher
Add soft limit on allowed number of script fields in request
c2d787a 
Requesting to many script_fields in a search request can be costly
because of script execution. This change introduces a soft limit on the number
of script fields that are allowed per request. The setting can be
changed per index using the index.max_script_fields setting.

Relates to elastic#26390
cbuescher added a commit that referenced this issue Sep 13, 2017
@cbuescher
Add soft limit on allowed number of script fields in request (#26598)
027c555 
Requesting to many script_fields in a search request can be costly
because of script execution. This change introduces a soft limit on the number
of script fields that are allowed per request. The setting can be
changed per index using the index.max_script_fields setting.

Relates to #26390
cbuescher added a commit that referenced this issue Sep 13, 2017
@cbuescher
Add soft limit on allowed number of script fields in request (#26598)
0e2dc29 
Requesting to many script_fields in a search request can be costly
because of script execution. This change introduces a soft limit on the number
of script fields that are allowed per request. The setting can be
changed per index using the index.max_script_fields setting.

Relates to #26390
cbuescher added a commit that referenced this issue Sep 13, 2017
@cbuescher
Add soft limit on allowed number of script fields in request (#26598)
c2acdcb 
Requesting to many script_fields in a search request can be costly
because of script execution. This change introduces a soft limit on the number
of script fields that are allowed per request. The setting can be
changed per index using the index.max_script_fields setting.

Relates to #26390
@cbuescher
Copy link
Member

Fixed by #26574 and #26598

iverase added a commit to iverase/elasticsearch that referenced this issue Aug 20, 2018
@iverase
Search: Support of wildcard on docvalue_fields
e307323 
For consistency with stored_fields, docvalue_fields should support the use of wildcards.

See also: elastic#26390

Closes elastic#26299
@iverase iverase mentioned this issue Aug 20, 2018
Merged
iverase added a commit that referenced this issue Aug 23, 2018
@iverase
Search: Support of wildcard on docvalue_fields (#32980)
d7219c0 
* Search: Support of wildcard on docvalue_fields

For consistency with stored_fields, docvalue_fields should support the use of wildcards. 
Documentation of doc values fields is updated accordingly.

See also: #26390

Closes #26299
iverase added a commit that referenced this issue Aug 23, 2018
@iverase
Search: Support of wildcard on docvalue_fields (#32980)
9a3d341 
* Search: Support of wildcard on docvalue_fields

For consistency with stored_fields, docvalue_fields should support the use of wildcards. 
Documentation of doc values fields is updated accordingly.

See also: #26390

Closes #26299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbuescher cbuescher

Labels
>enhancement help wanted adoptme :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpountz @cbuescher