Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose duplicate removal in the completion suggester #23364

Closed
mikemccand opened this issue Feb 25, 2017 · 1 comment
Closed

Expose duplicate removal in the completion suggester #23364

mikemccand opened this issue Feb 25, 2017 · 1 comment
Labels
>enhancement :Search Relevance/Suggesters "Did you mean" and suggestions as you type Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch

Comments

@mikemccand
Copy link
Contributor

Lucene 6.5.0 adds an option to the NRT document suggester to efficiently remove duplicates, and it's included in the last snapshot upgrade (#23362).

This should fix #22912, but I won't have time to work on it.
@mikemccand mikemccand added the :Search Relevance/Suggesters "Did you mean" and suggestions as you type label Feb 25, 2017
@abeyad abeyad self-assigned this Mar 17, 2017
@trompx
Copy link

trompx commented May 8, 2017

Hello @mikemccand,

Will this option be available for the context suggester too?

I index document question with a category property so I use the context suggester to suggest question when new documents are created and filtered by category so the completion suggester would not be enough for my usecase.

@abeyad abeyad removed their assignment May 23, 2017
@salper salper mentioned this issue Jul 16, 2017
Closed
@colings86 colings86 removed the help wanted adoptme label Aug 15, 2017
@jimczi jimczi mentioned this issue Sep 2, 2017
Closed
jimczi added a commit to jimczi/elasticsearch that referenced this issue Sep 4, 2017
@jimczi
Expose duplicate removal in the completion suggester
54c6ac7 
This change exposes the duplicate removal option added in Lucene for the completion suggester
with a new option called `skip_duplicates` (defaults to false).
This commit also adapts the custom suggest collector to handle deduplication when multiple contexts match the input.

Closes elastic#23364
@jimczi jimczi mentioned this issue Sep 4, 2017
Merged
jimczi added a commit that referenced this issue Sep 7, 2017
@jimczi
Expose duplicate removal in the completion suggester (#26496)
d68d8c9 
This change exposes the duplicate removal option added in Lucene for the completion suggester
with a new option called `skip_duplicates` (defaults to false).
This commit also adapts the custom suggest collector to handle deduplication when multiple contexts match the input.

Closes #23364
jimczi added a commit that referenced this issue Sep 11, 2017
@jimczi
Expose duplicate removal in the completion suggester (#26496)
46c1c3a 
This change exposes the duplicate removal option added in Lucene for the completion suggester
with a new option called `skip_duplicates` (defaults to false).
This commit also adapts the custom suggest collector to handle deduplication when multiple contexts match the input.

Closes #23364
@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement :Search Relevance/Suggesters "Did you mean" and suggestions as you type Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@clintongormley @colings86 @mikemccand @javanna @abeyad @trompx @andyb-elastic