Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Netty 4 advanced leak detection in tests and fail the build if there is a leak #20398

Closed
jasontedor opened this issue Sep 9, 2016 · 1 comment
Closed

Enable Netty 4 advanced leak detection in tests and fail the build if there is a leak #20398

jasontedor opened this issue Sep 9, 2016 · 1 comment
Labels
:Distributed Coordination/Network Http and internode communication implementations >enhancement

Comments

@jasontedor
Copy link
Member

Netty has pooled and unpooled byte buf alloactors. The pooled allocator uses reference counting to track when a byte buf can be returned to the pool, and leak detection to ensure that byte bufs are properly accessed/released. Netty has different levels of detection from disabled to paranoid (check every access). We should enable leak detection in tests and fail the build if a leak is detected.

Relates #19526, relates #19562
@jasontedor jasontedor added >enhancement :Distributed Coordination/Network Http and internode communication implementations labels Sep 9, 2016
@jasontedor jasontedor mentioned this issue Sep 9, 2016
Closed
5 tasks
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jul 6, 2018
@original-brownbear
TESTS: Check for Netty resource leaks
b7b0635 
* Enabled advanced leak detection when loading `EsTestCase`
* Added custom `Appender` to collect leak logs and check for logged errors in a way similar to what is done for the `StatusLogger`
* Fixes elastic#20398
@original-brownbear original-brownbear mentioned this issue Jul 6, 2018
Merged
@original-brownbear
Copy link
Member

Gave this a go in #31861 :)

original-brownbear added a commit that referenced this issue Jul 20, 2018
@original-brownbear
TESTS: Check for Netty resource leaks (#31861)
24068a7 
* Enabled advanced leak detection when loading `EsTestCase`
* Added custom `Appender` to collect leak logs and check for logged errors in a way similar to what is done for the `StatusLogger`
* Fixes #20398
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jul 20, 2018
@original-brownbear
TESTS: Check for Netty resource leaks (elastic#31861)
2edabdb 
* Enabled advanced leak detection when loading `EsTestCase`
* Added custom `Appender` to collect leak logs and check for logged errors in a way similar to what is done for the `StatusLogger`
* Fixes elastic#20398
@original-brownbear original-brownbear mentioned this issue Jul 20, 2018
Merged
original-brownbear added a commit that referenced this issue Jul 20, 2018
@original-brownbear
TESTS: Check for Netty resource leaks (#31861) (#32225)
bf1de2f 
* Enabled advanced leak detection when loading `EsTestCase`
* Added custom `Appender` to collect leak logs and check for logged errors in a way similar to what is done for the `StatusLogger`
* Fixes #20398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed Coordination/Network Http and internode communication implementations >enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasontedor @original-brownbear