Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field with dot in name to 2.4+ static bwc indexes #19956

Closed
rjernst opened this issue Aug 11, 2016 · 0 comments
Closed

Add field with dot in name to 2.4+ static bwc indexes #19956

rjernst opened this issue Aug 11, 2016 · 0 comments
Assignees
@s1monw
Labels
blocker >test Issues or PRs that are addressing/adding tests v5.0.0-beta1

Comments

@rjernst
Copy link
Member

rjernst commented Aug 11, 2016

With #19937 it is possible to force the system to allow dots in field names in 2.4. This is difficult to test because it relies on a temporary sysprop that only exists in 2.4. We should add a field with a dot in the name to static bwc indexes created for 2.4+ (and use that sysprop in create_bwc_index.py for any 2.4.x index).

This issue is a reminder to do so after 2.4 is released.
@rjernst rjernst added >test Issues or PRs that are addressing/adding tests blocker v5.0.0-beta1 labels Aug 11, 2016
@rjernst rjernst mentioned this issue Aug 11, 2016
Merged
s1monw added a commit to s1monw/elasticsearch that referenced this issue Sep 7, 2016
@s1monw
Add field with dot in name to 2.4+ static bwc indexes
bfa3415 
This change adds a `field.with.dots` to all 2.4 bwc indicse and above.
It also adds verification code to OldIndexBackwardsCompatibilityIT to
ensure we upgrade the indices cleanly and the field is present.

Closes elastic#19956
@s1monw s1monw mentioned this issue Sep 7, 2016
Merged
@s1monw s1monw self-assigned this Sep 7, 2016
s1monw added a commit that referenced this issue Sep 7, 2016
@s1monw
Add field with dot in name to 2.4+ static bwc indexes (#20360)
a96f3d4 
This change adds a `field.with.dots` to all 2.4 bwc indicse and above.
It also adds verification code to OldIndexBackwardsCompatibilityIT to
ensure we upgrade the indices cleanly and the field is present.

Closes #19956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
blocker >test Issues or PRs that are addressing/adding tests v5.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @rjernst @s1monw