Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Foreach Processor as experimental #19602

Closed
talevy opened this issue Jul 26, 2016 · 5 comments
Closed

Mark Foreach Processor as experimental #19602

talevy opened this issue Jul 26, 2016 · 5 comments
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes

Comments

@talevy
Copy link
Contributor

talevy commented Jul 26, 2016

From an offline discussion with @martijnvg and @BigFunger...

The foreach processor breaks many of the conventions of the other processors in Ingest.
It allows for a nested processor to execute in a separate context, and this separate context has been proven to be leaky.

Issues like #19601 and #19592 poke holes in the current interface we have designed. For these reasons, I think that the processor should be marked experimental for the upcoming 5.0 release. I do still think the processor adds a ton of value. We do not have many other tools for working with arrays in our documents, and this is a great tool for that.

@talevy talevy added discuss :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Jul 26, 2016
@talevy
Copy link
Contributor Author

talevy commented Jul 26, 2016

@clintongormley your thoughts on this issue would be great!

@jpountz
Copy link
Contributor

jpountz commented Jul 27, 2016

+1 to add the experimental annotation in case of any doubts about the stability of the API

@javanna
Copy link
Member

javanna commented Jul 27, 2016

but isn't ingest as a feature already experimental per se? do we want to make foreach super experimental? :)

@clintongormley
Copy link
Contributor

i'm good with calling out foreach as experimental. wondering if we should change the foreach model to avoid the issues (which i don't fully understand). perhaps tomorrow we can chat on zoom?

@martijnvg
Copy link
Member

I'll mark the foreach processor as experimental.

@martijnvg martijnvg added >docs General docs changes and removed discuss labels Sep 30, 2016
martijnvg added a commit that referenced this issue Sep 30, 2016
martijnvg added a commit that referenced this issue Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes
Projects
None yet
Development

No branches or pull requests

5 participants