-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Foreach Processor as experimental #19602
Comments
@clintongormley your thoughts on this issue would be great! |
+1 to add the |
but isn't ingest as a feature already experimental per se? do we want to make foreach super experimental? :) |
i'm good with calling out foreach as experimental. wondering if we should change the foreach model to avoid the issues (which i don't fully understand). perhaps tomorrow we can chat on zoom? |
I'll mark the foreach processor as experimental. |
From an offline discussion with @martijnvg and @BigFunger...
The foreach processor breaks many of the conventions of the other processors in Ingest.
It allows for a nested processor to execute in a separate context, and this separate context has been proven to be leaky.
Issues like #19601 and #19592 poke holes in the current interface we have designed. For these reasons, I think that the processor should be marked experimental for the upcoming 5.0 release. I do still think the processor adds a ton of value. We do not have many other tools for working with arrays in our documents, and this is a great tool for that.
The text was updated successfully, but these errors were encountered: