Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate and trim down the thread pools of a TransportClient #15472

Closed
bleskes opened this issue Dec 16, 2015 · 4 comments
Closed

Evaluate and trim down the thread pools of a TransportClient #15472

bleskes opened this issue Dec 16, 2015 · 4 comments

Comments

@bleskes
Copy link
Contributor

bleskes commented Dec 16, 2015

At the moment, for simplicity, the ThreadPool used by the TransportClient is the same as a full blown node. I.e., we have pools for things like BULK , SEARCH which are not relevant. Since we create threads lazily it's typically not a big deal as we will not spawn too many threads. However, it is error prone and conveys the wrong message to people extending functionality around the client like a BulkProcessor. IMO we should have a trimmed down set.

@s1monw
Copy link
Contributor

s1monw commented Dec 16, 2015

+1 - we might go even further and move all the threadpool stuff into a module and allow only this module to spawn threads etc? I know this is not what this issue is for but I wanted to get the idea out as @rmuir mentioned it to me a couple of times and I think it makes sense

@bleskes
Copy link
Contributor Author

bleskes commented Dec 16, 2015

Sounds good to me

On 16 dec. 2015 10:12 AM +0100, Simon [email protected], wrote:

+1 - we might go even further and move all the threadpool stuff into a module and allow only this module to spawn threads etc? I know this is not what this issue is for but I wanted to get the idea out as@rmuir(https://github.com/rmuir)mentioned it to me a couple of times and I think it makes sense


Reply to this email directly orview it on GitHub(#15472 (comment)).

@javanna
Copy link
Member

javanna commented Sep 22, 2017

Given that the high-level REST client will replace the transport client, I think that #26727 relates to this proposal, and may actually end up closing it.

@javanna
Copy link
Member

javanna commented Oct 25, 2017

Quick update: the Java high-level REST client no longer requires a ThreadPool but rather a lighter weight Scheduler which wraps a ScheduledThreadPoolExecutor. Given that we don't intend to spend time on fixing this in the transport client, and the current solution for the REST client is good, I am closing this issue.

@javanna javanna closed this as completed Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants