Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin manager should verify that it can write to all directories #12749

Closed
clintongormley opened this issue Aug 9, 2015 · 1 comment
Closed

Plugin manager should verify that it can write to all directories #12749

clintongormley opened this issue Aug 9, 2015 · 1 comment
Assignees
@spinscale
Labels
:Core/Infra/Plugins Plugin API and infrastructure >enhancement v2.0.0

Comments

@clintongormley
Copy link
Contributor

The plugin manager needs to validate it can write to the appropriate directories before it starts. Pretty sure today (1.x at least) it will half install a plugin when it can't write to certain directions
@clintongormley clintongormley mentioned this issue Aug 10, 2015
Closed
16 tasks
@spinscale
Copy link
Contributor

checked the code. There are no write permissions checks for bin/$PLUGIN/ and config/$PLUGIN/ - also you are right, we copy the plugin into the plugins directory and then try for bin and config directory, hoping all is fine...

@spinscale spinscale self-assigned this Aug 12, 2015
@spinscale spinscale mentioned this issue Aug 13, 2015
Merged
@nik9000 nik9000 removed the help wanted adoptme label Oct 7, 2015
spinscale added a commit to spinscale/elasticsearch that referenced this issue Oct 8, 2015
@spinscale
PluginManager: Dont leave leftover files on unsuccessful installs
70b2d90 
If the plugin manager cannot successfully install a plugin, ensure
that every directory is cleaned up again. This includes

plugins/foo
config/foo
bin/foo

Closes elastic#12749
spinscale added a commit that referenced this issue Oct 8, 2015
@spinscale
PluginManager: Dont leave leftover files on unsuccessful installs
158e66f 
If the plugin manager cannot successfully install a plugin, ensure
that every directory is cleaned up again. This includes

plugins/foo
config/foo
bin/foo

Closes #12749
spinscale added a commit that referenced this issue Oct 8, 2015
@spinscale
PluginManager: Dont leave leftover files on unsuccessful installs
e11fce8 
If the plugin manager cannot successfully install a plugin, ensure
that every directory is cleaned up again. This includes

plugins/foo
config/foo
bin/foo

Closes #12749
spinscale added a commit that referenced this issue Oct 8, 2015
@spinscale
PluginManager: Dont leave leftover files on unsuccessful installs
c89cef0 
If the plugin manager cannot successfully install a plugin, ensure
that every directory is cleaned up again. This includes

plugins/foo
config/foo
bin/foo

Closes #12749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spinscale spinscale

Labels
:Core/Infra/Plugins Plugin API and infrastructure >enhancement v2.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @nik9000 @spinscale