Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to improve integration tests setup/teardown #12063

Closed
rmuir opened this issue Jul 6, 2015 · 4 comments
Closed

try to improve integration tests setup/teardown #12063

rmuir opened this issue Jul 6, 2015 · 4 comments
Assignees
Labels
>test Issues or PRs that are addressing/adding tests

Comments

@rmuir
Copy link
Contributor

rmuir commented Jul 6, 2015

Integration test logic starts up ES with all defaults (and for plugins installs a plugin). the teardown phase basically does 'killall elasticsearch'. Currently this stuff is just done the same way the python release script did things.

Ideally these could be more fine-grained, maybe read from a PID file instead, maybe use a non-default port number, etc.

@rmuir rmuir added the >test Issues or PRs that are addressing/adding tests label Jul 6, 2015
@spinscale
Copy link
Contributor

I think we can we close, since stop-external-cluster uses the pid file for killing the process, see https://github.com/elastic/elasticsearch/blob/master/dev-tools/src/main/resources/ant/integration-tests.xml#L281

we still might work on the TODO though

@clintongormley
Copy link
Contributor

@brwe please could you look at this TODO

@brwe
Copy link
Contributor

brwe commented Aug 26, 2015

todo has been taken care of in #12961. can we close this?

@clintongormley
Copy link
Contributor

Looks like it, thanks @brwe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

No branches or pull requests

4 participants