-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to improve integration tests setup/teardown #12063
Labels
>test
Issues or PRs that are addressing/adding tests
Comments
This was referenced Jul 6, 2015
16 tasks
I think we can we close, since we still might work on the TODO though |
@brwe please could you look at this TODO |
brwe
added a commit
to brwe/elasticsearch
that referenced
this issue
Aug 18, 2015
…lasticsearch process relates to elastic#12063
todo has been taken care of in #12961. can we close this? |
Looks like it, thanks @brwe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Integration test logic starts up ES with all defaults (and for plugins installs a plugin). the teardown phase basically does 'killall elasticsearch'. Currently this stuff is just done the same way the python release script did things.
Ideally these could be more fine-grained, maybe read from a PID file instead, maybe use a non-default port number, etc.
The text was updated successfully, but these errors were encountered: