Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] RecoverySourcePruneMergePolicyTests testPruneSome failing #118728

Closed
elasticsearchmachine opened this issue Dec 15, 2024 · 4 comments · Fixed by #118944
Closed

[CI] RecoverySourcePruneMergePolicyTests testPruneSome failing #118728

elasticsearchmachine opened this issue Dec 15, 2024 · 4 comments · Fixed by #118944
Assignees
@arteam
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. low-risk An open issue or test failure that is a low risk to future releases :StorageEngine/Logs You know, for Logs Team:Distributed Indexing Meta label for Distributed Indexing team Team:StorageEngine >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Dec 15, 2024 •
edited
Loading

Build Scans:

Reproduction Line:

./gradlew ":server:test" --tests "org.elasticsearch.index.engine.RecoverySourcePruneMergePolicyTests.testPruneSome" -Dtests.seed=A8E66C85BDF740CF -Dtests.locale=ko-CN -Dtests.timezone=SST -Druntime.java=23

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: 
Expected: a value greater than <10L>
     but: <10L> was equal to <10L>

Issue Reasons:

  • [main] 5 failures in test testPruneSome (0.8% fail rate in 620 executions)
  • [main] 2 failures in step part-1 (0.8% fail rate in 252 executions)
  • [main] 2 failures in pipeline elasticsearch-pull-request (0.8% fail rate in 250 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >test-failure Triaged test failures from CI labels Dec 15, 2024
elasticsearchmachine added a commit that referenced this issue Dec 15, 2024
@elasticsearchmachine
Mute org.elasticsearch.index.engine.RecoverySourcePruneMergePolicyTes…
329a3b0 
…ts testPruneSome #118728
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch 8.x

Mute Reasons:

  • [8.x] 3 failures in test testPruneSome (1.1% fail rate in 281 executions)

Build Scans:

@elasticsearchmachine elasticsearchmachine added needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Distributed Indexing Meta label for Distributed Indexing team labels Dec 15, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

@arteam arteam self-assigned this Dec 16, 2024
@arteam arteam added the low-risk An open issue or test failure that is a low risk to future releases label Dec 16, 2024
@elasticsearchmachine elasticsearchmachine removed the needs:risk Requires assignment of a risk label (low, medium, blocker) label Dec 16, 2024
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this issue Dec 16, 2024
@elasticsearchmachine @maxhniebergall
Mute org.elasticsearch.index.engine.RecoverySourcePruneMergePolicyTes…
06dd703 
…ts testPruneSome elastic#118728
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 5 failures in test testPruneSome (0.8% fail rate in 620 executions)
  • [main] 2 failures in step part-1 (0.8% fail rate in 252 executions)
  • [main] 2 failures in pipeline elasticsearch-pull-request (0.8% fail rate in 250 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Dec 17, 2024
@elasticsearchmachine
Mute org.elasticsearch.index.engine.RecoverySourcePruneMergePolicyTes…
312c21a 
…ts testPruneSome #118728
arteam added a commit to arteam/elasticsearch that referenced this issue Dec 18, 2024
@arteam
[test] Fix RecoverySourcePruneMergePolicyTests#testPruneSome
e7c4ba1 
The `extra_source_size` field is set to a value between 10 and 10000 inclusive, so
the assertion should be `greaterThanOrEqualTo(10)` rather than greaterThan(10).

Resolve elastic#118728
@arteam arteam mentioned this issue Dec 18, 2024
Merged
@arteam arteam added the :StorageEngine/Logs You know, for Logs label Dec 18, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-storage-engine (Team:StorageEngine)

rjernst pushed a commit to rjernst/elasticsearch that referenced this issue Dec 18, 2024
@arteam @rjernst
[test] Fix RecoverySourcePruneMergePolicyTests#testPruneSome (elastic…
2d929e6 
…#118944)

The `extra_source_size` field is set to a value between 10 and 10000
inclusive, so the assertion should be `greaterThanOrEqualTo(10)` rather
than `greaterThan(10)`.

See elastic#114618 Resolve elastic#118728
@arteam arteam mentioned this issue Dec 18, 2024
Merged
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue Dec 19, 2024
@martijnvg
Removed forgotten test mute
b421208 
The test failure elastic#118728 was fixed by elastic#118944 but test wasn't unmuted.
@martijnvg martijnvg mentioned this issue Dec 19, 2024
Merged
martijnvg added a commit that referenced this issue Dec 19, 2024
@martijnvg
Removed forgotten test mute (#119092)
338d2bd 
The test failure #118728 was fixed by #118944 but test wasn't unmuted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arteam arteam

Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. low-risk An open issue or test failure that is a low risk to future releases :StorageEngine/Logs You know, for Logs Team:Distributed Indexing Meta label for Distributed Indexing team Team:StorageEngine >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
2 participants
@arteam @elasticsearchmachine