Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] RoleDescriptorTests testHasPrivilegesOtherThanIndex failing #116376

Closed
elasticsearchmachine opened this issue Nov 7, 2024 · 3 comments · Fixed by #116852
Closed

[CI] RoleDescriptorTests testHasPrivilegesOtherThanIndex failing #116376

elasticsearchmachine opened this issue Nov 7, 2024 · 3 comments · Fixed by #116852
Assignees
@jakelandis
Labels
low-risk An open issue or test failure that is a low risk to future releases :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

Build Scans:

Reproduction Line:

./gradlew ":x-pack:plugin:core:test" --tests "org.elasticsearch.xpack.core.security.authz.RoleDescriptorTests.testHasPrivilegesOtherThanIndex" -Dtests.seed=3E7C1BBDCB190C72 -Dtests.jvm.argline="-Des.concurrent_search=true" -Dtests.locale=es-SV -Dtests.timezone=America/Kentucky/Monticello -Druntime.java=23

Applicable branches:
8.x

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: 
Expected: <false>
     but: was <true>

Issue Reasons:

  • [8.x] 2 failures in test testHasPrivilegesOtherThanIndex (0.3% fail rate in 789 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC >test-failure Triaged test failures from CI labels Nov 7, 2024
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch 8.x

Mute Reasons:

  • [8.x] 2 failures in test testHasPrivilegesOtherThanIndex (0.3% fail rate in 789 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Nov 7, 2024
@elasticsearchmachine
Mute org.elasticsearch.xpack.core.security.authz.RoleDescriptorTests …
7641277 
…testHasPrivilegesOtherThanIndex #116376
@elasticsearchmachine elasticsearchmachine added Team:Security Meta label for security team needs:risk Requires assignment of a risk label (low, medium, blocker) labels Nov 7, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-security (Team:Security)

@gwbrown gwbrown self-assigned this Nov 8, 2024
@jakelandis jakelandis mentioned this issue Nov 14, 2024
Merged
@jakelandis jakelandis added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Nov 14, 2024
@jakelandis jakelandis assigned jakelandis and unassigned gwbrown Nov 14, 2024
@jakelandis
Copy link
Contributor

this is small bug in the test which #116852 will fix

jakelandis added a commit that referenced this issue Nov 19, 2024
@jakelandis
Fix RoleDescriptor test that fails randomly (#116852)
0795703 
This commit fixes a test fails based on the random seed.
The change updates the name of the test to match the updated name of the method it is testing.
It also re-implements the test to rely less on randomness and explicitly tests the possible inputs.

fixes #116376
jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Nov 19, 2024
@jakelandis
Fix RoleDescriptor test that fails randomly (elastic#116852)
fb6410f 
This commit fixes a test fails based on the random seed.
The change updates the name of the test to match the updated name of the method it is testing.
It also re-implements the test to rely less on randomness and explicitly tests the possible inputs.

fixes elastic#116376

(cherry picked from commit 0795703)
jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Nov 19, 2024
@jakelandis
Fix RoleDescriptor test that fails randomly (elastic#116852)
9dec597 
This commit fixes a test fails based on the random seed.
The change updates the name of the test to match the updated name of the method it is testing.
It also re-implements the test to rely less on randomness and explicitly tests the possible inputs.

fixes elastic#116376

(cherry picked from commit 0795703)

# Conflicts:
#	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptorTests.java
jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Nov 19, 2024
@jakelandis
Fix RoleDescriptor test that fails randomly (elastic#116852)
e2bdede 
This commit fixes a test fails based on the random seed.
The change updates the name of the test to match the updated name of the method it is testing.
It also re-implements the test to rely less on randomness and explicitly tests the possible inputs.

fixes elastic#116376

(cherry picked from commit 0795703)

# Conflicts:
#	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptorTests.java
elasticsearchmachine pushed a commit that referenced this issue Nov 19, 2024
@jakelandis
Fix RoleDescriptor test that fails randomly (#116852) (#117030)
8b8ae59 
This commit fixes a test fails based on the random seed.
The change updates the name of the test to match the updated name of the method it is testing.
It also re-implements the test to rely less on randomness and explicitly tests the possible inputs.

fixes #116376

(cherry picked from commit 0795703)
elasticsearchmachine pushed a commit that referenced this issue Nov 19, 2024
@jakelandis
[8.16] Fix RoleDescriptor test that fails randomly (#116852) (#117031)
1e1a67c 
* Fix RoleDescriptor test that fails randomly (#116852)

This commit fixes a test fails based on the random seed.
The change updates the name of the test to match the updated name of the method it is testing.
It also re-implements the test to rely less on randomness and explicitly tests the possible inputs.

fixes #116376

(cherry picked from commit 0795703)

# Conflicts:
#	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptorTests.java

* remove rouge import
elasticsearchmachine pushed a commit that referenced this issue Nov 19, 2024
@jakelandis
[8.15] Fix RoleDescriptor test that fails randomly (#116852) (#117032)
f1376de 
* Fix RoleDescriptor test that fails randomly (#116852)

This commit fixes a test fails based on the random seed.
The change updates the name of the test to match the updated name of the method it is testing.
It also re-implements the test to rely less on randomness and explicitly tests the possible inputs.

fixes #116376

(cherry picked from commit 0795703)

# Conflicts:
#	x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptorTests.java

* remove rouge import
rjernst pushed a commit to rjernst/elasticsearch that referenced this issue Nov 20, 2024
@jakelandis @rjernst
Fix RoleDescriptor test that fails randomly (elastic#116852)
41abb63 
This commit fixes a test fails based on the random seed.
The change updates the name of the test to match the updated name of the method it is testing.
It also re-implements the test to rely less on randomness and explicitly tests the possible inputs.

fixes elastic#116376
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this issue Nov 28, 2024
@jakelandis @alexey-ivanov-es
Fix RoleDescriptor test that fails randomly (elastic#116852)
b79c8da 
This commit fixes a test fails based on the random seed.
The change updates the name of the test to match the updated name of the method it is testing.
It also re-implements the test to rely less on randomness and explicitly tests the possible inputs.

fixes elastic#116376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakelandis jakelandis

Labels
low-risk An open issue or test failure that is a low risk to future releases :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RoleDescriptor test that fails randomly jakelandis/elasticsearch
3 participants
@jakelandis @gwbrown @elasticsearchmachine