Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: prevent usage of BUCKET in agg filters #115521

Closed
bpintea opened this issue Oct 24, 2024 · 2 comments
Closed

ESQL: prevent usage of BUCKET in agg filters #115521

bpintea opened this issue Oct 24, 2024 · 2 comments
Assignees
@bpintea
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@bpintea
Copy link
Contributor

bpintea commented Oct 24, 2024

Using BUCKET in agg filters should not be allowed (as it's a grouping function). See example here.

Related #113735
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 24, 2024
@bpintea bpintea mentioned this issue Oct 24, 2024
Merged
@bpintea bpintea self-assigned this Nov 13, 2024
@bpintea bpintea mentioned this issue Nov 20, 2024
Merged
@bpintea
Copy link
Contributor Author

bpintea commented Nov 20, 2024

This has been already working as intended: reuse of expression from grouping allowed, but other not. Adding testing in #117184.

@bpintea bpintea closed this as completed Nov 20, 2024
elasticsearchmachine pushed a commit that referenced this issue Nov 21, 2024
@bpintea
ESQL: add tests on use of grouping functions in agg filters (#117184)
fefa0f0 
Add tests on use of grouping functions in agg filters: check that
reusing the BUCKET expression from grouping is allowed, but no other
variation.

Related: #115521
bpintea added a commit to bpintea/elasticsearch that referenced this issue Nov 21, 2024
@bpintea
ESQL: add tests on use of grouping functions in agg filters (elastic#…
fe37456 
…117184)

Add tests on use of grouping functions in agg filters: check that
reusing the BUCKET expression from grouping is allowed, but no other
variation.

Related: elastic#115521
(cherry picked from commit fefa0f0)
@bpintea bpintea mentioned this issue Nov 21, 2024
Merged
elasticsearchmachine pushed a commit that referenced this issue Nov 21, 2024
@bpintea
ESQL: add tests on use of grouping functions in agg filters (#117184) (…
0a9883c 
…#117262)

Add tests on use of grouping functions in agg filters: check that
reusing the BUCKET expression from grouping is allowed, but no other
variation.

Related: #115521
(cherry picked from commit fefa0f0)
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this issue Nov 28, 2024
@bpintea @alexey-ivanov-es
ESQL: add tests on use of grouping functions in agg filters (elastic#…
bdbad11 
…117184)

Add tests on use of grouping functions in agg filters: check that
reusing the BUCKET expression from grouping is allowed, but no other
variation.

Related: elastic#115521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpintea bpintea

Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpintea @elasticsearchmachine