Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] FileSettingsRoleMappingUpgradeIT testRoleMappingsAppliedOnUpgrade {upgradedNodes=3} failing #115411

Closed
elasticsearchmachine opened this issue Oct 23, 2024 · 2 comments · Fixed by #115422
Closed

[CI] FileSettingsRoleMappingUpgradeIT testRoleMappingsAppliedOnUpgrade {upgradedNodes=3} failing #115411

elasticsearchmachine opened this issue Oct 23, 2024 · 2 comments · Fixed by #115422
Assignees
@n1v0lg
Labels
low-risk An open issue or test failure that is a low risk to future releases :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 23, 2024 •
edited
Loading

Build Scans:

Reproduction Line:

./gradlew ":qa:rolling-upgrade:v8.5.3#bwcTest" -Dtests.class="org.elasticsearch.upgrades.FileSettingsRoleMappingUpgradeIT" -Dtests.method="testRoleMappingsAppliedOnUpgrade {upgradedNodes=3}" -Dtests.seed=6D5E9D1982DF22BB -Dtests.bwc=true -Dtests.locale=yo-NG -Dtests.timezone=Asia/Baghdad -Druntime.java=23

Applicable branches:
8.x

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: 
Expected: is an instance of java.util.Map
     but: <[{metadata={_es_reserved_role_mapping_name=everyone_kibana}, roles=[kibana_user], rules={field={username=*}}, enabled=true}]> is a java.util.ArrayList

Issue Reasons:

  • [8.x] 22 consecutive failures in test testRoleMappingsAppliedOnUpgrade {upgradedNodes=3}
  • [8.x] 2 consecutive failures in step 8.14.3_bwc
  • [8.x] 2 consecutive failures in step 8.13.4_bwc
  • [8.x] 2 consecutive failures in step 8.8.2_bwc
  • [8.x] 2 consecutive failures in step 8.11.4_bwc
  • [8.x] 2 consecutive failures in step 8.12.2_bwc
  • [8.x] 2 consecutive failures in step 8.10.4_bwc
  • [8.x] 2 consecutive failures in step 8.5.3_bwc
  • [8.x] 2 consecutive failures in step 8.4.3_bwc
  • [8.x] 2 consecutive failures in step 8.9.2_bwc
  • [8.x] 2 consecutive failures in step 8.7.1_bwc
  • [8.x] 2 consecutive failures in step 8.6.2_bwc
  • [8.x] 2 consecutive failures in pipeline elasticsearch-periodic
  • [8.x] 22 failures in test testRoleMappingsAppliedOnUpgrade {upgradedNodes=3} (52.4% fail rate in 42 executions)
  • [8.x] 2 failures in step 8.14.3_bwc (50.0% fail rate in 4 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) >test-failure Triaged test failures from CI Team:Security Meta label for security team needs:risk Requires assignment of a risk label (low, medium, blocker) labels Oct 23, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-security (Team:Security)

@n1v0lg n1v0lg self-assigned this Oct 23, 2024
@n1v0lg
Copy link
Contributor

n1v0lg commented Oct 23, 2024

Urgh yes this is a broken assertion

@n1v0lg n1v0lg added the low-risk An open issue or test failure that is a low risk to future releases label Oct 23, 2024
@elasticsearchmachine elasticsearchmachine removed the needs:risk Requires assignment of a risk label (low, medium, blocker) label Oct 23, 2024
This was referenced Oct 23, 2024
Closed
Merged
n1v0lg added a commit to n1v0lg/elasticsearch that referenced this issue Oct 23, 2024
@n1v0lg
Fix FileSettingsRoleMappingUpgradeIT assertions (elastic#115422)
a1d0120 
Fixes some faulty assertions in an upgrade test. Test failures only
manifest on the 8.16 branch since 9.x does not qualify for these upgrade
tests, and the change is not backported to 8.17 yet (unrelated CI
failures).

I validated this works by running it locally from the 8.16 branch.

Resolves: elastic#115410
Resolves: elastic#115411
n1v0lg added a commit to n1v0lg/elasticsearch that referenced this issue Oct 23, 2024
@n1v0lg
Fix FileSettingsRoleMappingUpgradeIT assertions (elastic#115422)
905d3b0 
Fixes some faulty assertions in an upgrade test. Test failures only
manifest on the 8.16 branch since 9.x does not qualify for these upgrade
tests, and the change is not backported to 8.17 yet (unrelated CI
failures).

I validated this works by running it locally from the 8.16 branch.

Resolves: elastic#115410
Resolves: elastic#115411
elasticsearchmachine pushed a commit that referenced this issue Oct 23, 2024
@n1v0lg
Fix FileSettingsRoleMappingUpgradeIT assertions (#115422) (#115468)
67a7682 
Fixes some faulty assertions in an upgrade test. Test failures only
manifest on the 8.16 branch since 9.x does not qualify for these upgrade
tests, and the change is not backported to 8.17 yet (unrelated CI
failures).

I validated this works by running it locally from the 8.16 branch.

Resolves: #115410
Resolves: #115411
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this issue Oct 23, 2024
@n1v0lg @smalyshev
Fix FileSettingsRoleMappingUpgradeIT assertions (elastic#115422)
cb20409 
Fixes some faulty assertions in an upgrade test. Test failures only
manifest on the 8.16 branch since 9.x does not qualify for these upgrade
tests, and the change is not backported to 8.17 yet (unrelated CI
failures).

I validated this works by running it locally from the 8.16 branch.

Resolves: elastic#115410
Resolves: elastic#115411
elasticsearchmachine pushed a commit that referenced this issue Oct 24, 2024
@n1v0lg @elasticmachine
Fix FileSettingsRoleMappingUpgradeIT assertions (#115422) (#115469)
2e58124 
Fixes some faulty assertions in an upgrade test. Test failures only
manifest on the 8.16 branch since 9.x does not qualify for these upgrade
tests, and the change is not backported to 8.17 yet (unrelated CI
failures).

I validated this works by running it locally from the 8.16 branch.

Resolves: #115410
Resolves: #115411

Co-authored-by: Elastic Machine <[email protected]>
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this issue Oct 25, 2024
@n1v0lg @georgewallace
Fix FileSettingsRoleMappingUpgradeIT assertions (elastic#115422)
82e285f 
Fixes some faulty assertions in an upgrade test. Test failures only
manifest on the 8.16 branch since 9.x does not qualify for these upgrade
tests, and the change is not backported to 8.17 yet (unrelated CI
failures).

I validated this works by running it locally from the 8.16 branch.

Resolves: elastic#115410
Resolves: elastic#115411
jfreden pushed a commit to jfreden/elasticsearch that referenced this issue Nov 4, 2024
@n1v0lg @jfreden
Fix FileSettingsRoleMappingUpgradeIT assertions (elastic#115422)
9f4f7f9 
Fixes some faulty assertions in an upgrade test. Test failures only
manifest on the 8.16 branch since 9.x does not qualify for these upgrade
tests, and the change is not backported to 8.17 yet (unrelated CI
failures).

I validated this works by running it locally from the 8.16 branch.

Resolves: elastic#115410
Resolves: elastic#115411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n1v0lg n1v0lg

Labels
low-risk An open issue or test failure that is a low risk to future releases :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix FileSettingsRoleMappingUpgradeIT assertions n1v0lg/elasticsearch
2 participants
@n1v0lg @elasticsearchmachine