Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] RepositoryVerifyIntegrityIT testCorruption failing #112769

Closed
elasticsearchmachine opened this issue Sep 11, 2024 · 2 comments · Fixed by #112778
Closed

[CI] RepositoryVerifyIntegrityIT testCorruption failing #112769

elasticsearchmachine opened this issue Sep 11, 2024 · 2 comments · Fixed by #112778
Assignees
@ywangd
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs low-risk An open issue or test failure that is a low risk to future releases Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Sep 11, 2024 •
edited
Loading

Build Scans:

Reproduction Line:

./gradlew ":x-pack:plugin:snapshot-repo-test-kit:internalClusterTest" --tests "org.elasticsearch.repositories.blobstore.testkit.integrity.RepositoryVerifyIntegrityIT.testCorruption" -Dtests.seed=4C617F002EA1A2D6 -Dtests.locale=be-BY -Dtests.timezone=America/Danmarkshavn -Druntime.java=22

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: 
Expected: not an empty collection
     but: was <[]>

Issue Reasons:

  • [main] 5 failures in test testCorruption (12.8% fail rate in 39 executions)
  • [main] 2 failures in step part-2 (10.5% fail rate in 19 executions)
  • [main] 2 failures in pipeline elasticsearch-pull-request (11.1% fail rate in 18 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI labels Sep 11, 2024
elasticsearchmachine added a commit that referenced this issue Sep 11, 2024
@elasticsearchmachine
Mute org.elasticsearch.repositories.blobstore.testkit.integrity.Repos…
794ea74 
…itoryVerifyIntegrityIT testCorruption #112769
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 4 failures in test testCorruption (10.8% fail rate in 37 executions)
  • [main] 2 failures in step part-2 (11.1% fail rate in 18 executions)
  • [main] 2 failures in pipeline elasticsearch-pull-request (11.8% fail rate in 17 executions)

Build Scans:

@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. needs:risk Requires assignment of a risk label (low, medium, blocker) labels Sep 11, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-distributed (Team:Distributed)

@ywangd ywangd self-assigned this Sep 11, 2024
@ywangd ywangd added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Sep 12, 2024
ywangd added a commit to ywangd/elasticsearch that referenced this issue Sep 12, 2024
@ywangd
[Test] Account for auto-repairing for shard gen file
ae199c4 
Since elastic#112337, missing shard gen files are automatically reconstructed
based on the existing shard snapshot files. If the list of shard
snapshot files are completed, it means the repository is effectively not
corrupted. This PR updates the test to account for this situation.

Resolves: elastic#112769
@ywangd ywangd mentioned this issue Sep 12, 2024
Merged
ywangd added a commit to ywangd/elasticsearch that referenced this issue Sep 12, 2024
@ywangd
[Test] Account for auto-repairing for shard gen file (elastic#112778)
801f306 
Since elastic#112337, missing shard gen files are automatically reconstructed
based on the existing shard snapshot files. If the list of shard
snapshot files is complete, it means the repository is effectively not
corrupted. This PR updates the test to account for this situation.

Resolves: elastic#112769
(cherry picked from commit e1f7814)

# Conflicts:
#	muted-tests.yml
v1v added a commit to v1v/elasticsearch that referenced this issue Sep 12, 2024
@v1v
Merge remote-tracking branch 'upstream/main' into feature/bump-automa…
48c937f 
…tion-ironbank-ubi

* upstream/main: (302 commits)
  Deduplicate BucketOrder when deserializing (elastic#112707)
  Introduce test utils for ingest pipelines (elastic#112733)
  [Test] Account for auto-repairing for shard gen file (elastic#112778)
  Do not throw in task enqueued by CancellableRunner (elastic#112780)
  Mute org.elasticsearch.script.StatsSummaryTests testEqualsAndHashCode elastic#112439
  Mute org.elasticsearch.repositories.blobstore.testkit.integrity.RepositoryVerifyIntegrityIT testTransportException elastic#112779
  Use a dedicated test executor in MockTransportService (elastic#112748)
  Estimate segment field usages (elastic#112760)
  (Doc+) Inference Pipeline ignores Mapping Analyzers (elastic#112522)
  Fix verifyVersions task (elastic#112765)
  (Doc+) Terminating Exit Codes (elastic#112530)
  (Doc+) CAT Nodes default columns (elastic#112715)
  [DOCS] Augment installation warnings (elastic#112756)
  Mute org.elasticsearch.repositories.blobstore.testkit.integrity.RepositoryVerifyIntegrityIT testCorruption elastic#112769
  Bump Elasticsearch to a minimum of JDK 21 (elastic#112252)
  ESQL: Compute support for filtering ungrouped aggs (elastic#112717)
  Bump Elasticsearch version to 9.0.0 (elastic#112570)
  add CDR related data streams to kibana_system priviliges (elastic#112655)
  Support widening of numeric types in union-types (elastic#112610)
  Introduce data stream options and failure store configuration classes (elastic#109515)
  ...
elasticsearchmachine pushed a commit that referenced this issue Sep 12, 2024
@ywangd
[Test] Account for auto-repairing for shard gen file (#112778) (#112788)
4f17b4a 
Since #112337, missing shard gen files are automatically reconstructed
based on the existing shard snapshot files. If the list of shard
snapshot files is complete, it means the repository is effectively not
corrupted. This PR updates the test to account for this situation.

Resolves: #112769
(cherry picked from commit e1f7814)

# Conflicts:
#	muted-tests.yml
davidkyle pushed a commit that referenced this issue Sep 12, 2024
@elasticsearchmachine @davidkyle
Mute org.elasticsearch.repositories.blobstore.testkit.integrity.Repos…
a211d80 
…itoryVerifyIntegrityIT testCorruption #112769
davidkyle pushed a commit that referenced this issue Sep 12, 2024
@ywangd @davidkyle
[Test] Account for auto-repairing for shard gen file (#112778)
ca30b69 
Since #112337, missing shard gen files are automatically reconstructed
based on the existing shard snapshot files. If the list of shard
snapshot files is complete, it means the repository is effectively not
corrupted. This PR updates the test to account for this situation.

Resolves: #112769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywangd ywangd

Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs low-risk An open issue or test failure that is a low risk to future releases Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Test] Account for auto-repairing for shard gen file ywangd/elasticsearch
2 participants
@ywangd @elasticsearchmachine