Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure settings are permitted in elasticsearch.yml if also present in keystore #109115

Closed
DaveCTurner opened this issue May 28, 2024 · 1 comment · Fixed by #115779
Closed

Secure settings are permitted in elasticsearch.yml if also present in keystore #109115

DaveCTurner opened this issue May 28, 2024 · 1 comment · Fixed by #115779
Assignees
Labels
>bug :Core/Infra/Settings Settings infrastructure and APIs Team:Core/Infra Meta label for core/infra team

Comments

@DaveCTurner
Copy link
Contributor

Elasticsearch should refuse to start if a secure setting is defined in elasticsearch.yml, in order to protect users from accidentally putting their secrets in a place where they are unexpectedly visible. However, settings in the keystore apparently quietly override those in elasticsearch.yml, which means that if you put a secure setting in both places then Elasticsearch will use the one from the keystore and will totally ignore the one in elasticsearch.yml instead of refusing to start.

@DaveCTurner DaveCTurner added >bug :Core/Infra/Settings Settings infrastructure and APIs labels May 28, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 28, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@alexey-ivanov-es alexey-ivanov-es self-assigned this Oct 17, 2024
alexey-ivanov-es added a commit to alexey-ivanov-es/elasticsearch that referenced this issue Oct 28, 2024
Elasticsearch should refuse to start
if a secure setting is defined in elasticsearch.yml,
in order to protect users from accidentally putting their secrets
in a place where they are unexpectedly visible

Fixes elastic#109115
alexey-ivanov-es added a commit that referenced this issue Nov 4, 2024
* Don't allow secure settings in YML config (109115)

Elasticsearch should refuse to start
if a secure setting is defined in elasticsearch.yml,
in order to protect users from accidentally putting their secrets
in a place where they are unexpectedly visible

Fixes #109115
jozala pushed a commit that referenced this issue Nov 13, 2024
* Don't allow secure settings in YML config (109115)

Elasticsearch should refuse to start
if a secure setting is defined in elasticsearch.yml,
in order to protect users from accidentally putting their secrets
in a place where they are unexpectedly visible

Fixes #109115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Settings Settings infrastructure and APIs Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants