Universal Profiling cleanups for 9.0.0

[danielmitterdorfer]

This is a meta-issue to collect all cleanups to be done for the next major version.

Tasks

Preview Give feedback

1. [Profiling, 9.0.0] Remove unused fields from the stacktraces and flamegraph API #106593
   :UniversalProfiling/Application Team:obs-knowledge +2
2. [Profiling, 9.0.0] Remove backwards compatibility code in CO2 calculator #106596
   :UniversalProfiling/Application Team:obs-knowledge +2
3. [Profiling, 9.0.0] Remove backwards compatibility code for host.arch #106597
   :UniversalProfiling/Application Team:obs-knowledge +2
4. [Profiling, 9.0.0] Remove backwards compatibility for missing cloud.provider, cloud.region, host.type #106681
   :UniversalProfiling/Application Team:obs-knowledge +2
5. [Profiling UI, 9.0.0] Clean up unused ES fields that will be removed in 9.0.0 kibana#204024
   Feature:UniversalProfiling Team:obs-ux-infra_services v9.0.0 +3
   

[elasticsearchmachine]

Pinging @elastic/obs-knowledge-team (Team:obs-knowledge)

[DaveCTurner]

I'd suggest adding the @UpdateForV9 annotation to relevant points in the code to keep track of these things today. When we decide to start working on v9, we'll go through all the places where this annotation is used to make sure we don't miss anything.

[danielmitterdorfer]

I'd suggest adding the @UpdateForV9 annotation to relevant points in the code to keep track of these things [...]

Thanks. I've pushed #107150.

[simitt]

@rockdaboot my understanding is that this meta issue was closed based on some 9.0 annotations being added to Elasticsearch. How are the annotations used now that we get close to 9.0 - do we still need to put up PRs to actually remove the logic or is there some automation happening around these annotations?

[DaveCTurner]

No, there's no way to automate this. Each @UpdateForV9 annotation needs a manual PR to address the point that needs updating.

[simitt]

Reopening this github card to not lose track of the work that needs to go into 9.0 then. @paulb-elastic this task was labeled for the UniversalProfiling/Application, and skimming through the sections I believe this is the correct label, hence IMO this would fall into the @elastic/obs-ux-infra_services-team .

[rockdaboot]

Thanks for the clarification. So far, i assumed some automation with 9.0 to make the annotations visible and/or ping teams. What exactly are those annotations used for?

[DaveCTurner]

They exist to prevent us from releasing v9 without addressing all the things that need addressing first: we will not release v9 without deleting this file, and we cannot do that while the @UpdateForV9 annotation is still in use.

In principle we could write a bot to go around pinging teams about the work that they must do, but so far we've just been tracking this manually at the team level (see e.g. ES-9364). It's very easy to ask IntelliJ to find all the outstanding actions for a specific team in the codebase - just look for usages of the relevant UpdateForV9.Owner constant.

It's likely that this work will only proceed in earnest after the 8.last feature freeze. Until that happens, we're required to keep the transport protocol aligned between the 8.x and main branches, and that prevents us from addressing many of the tasks on this list.

I do note that the profiling team's work is not being tracked in Jira right now. I'm not sure why that is.

[paulb-elastic]

@smith I have added a link to this to our main tracking meta https://github.com/elastic/observability-dev/issues/4143 for your team's v9 activities

[elasticsearchmachine]

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)