Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get field mapping api should check for metadata blocks #10521

Closed
javanna opened this issue Apr 10, 2015 · 0 comments · Fixed by #9203
Closed

get field mapping api should check for metadata blocks #10521

javanna opened this issue Apr 10, 2015 · 0 comments · Fixed by #9203
Assignees
@tlrx
Labels
>bug :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v1.6.0 v2.0.0-beta1

Comments

@javanna
Copy link
Member

javanna commented Apr 10, 2015

The get field mapping api currently checks for data read blocks rather than metadata blocks. Seems like a bug given that the api allows to retrieve mappings and not data. This can be seen by adding a metadata block to an index and then calling the get field mapping api, which works while it should be rejected.

The problem might stem from the fact that metadata block currently means read and write, causing different issues, which will be solved with #9203. Once that is in we will be able to only check for metadata read blocks instead.
@javanna javanna mentioned this issue Apr 10, 2015
Merged
tlrx added a commit to tlrx/elasticsearch that referenced this issue Apr 10, 2015
@tlrx
Internal: Add METADATA_READ and METADATA_WRITE blocks
172c267 
This commit splits the current ClusterBlockLevel.METADATA into two disctins ClusterBlockLevel.METADATA_READ and ClusterBlockLevel.METADATA_WRITE blocks. It allows to make a distinction between
an operation that modifies the index or cluster metadata and an operation that does not change any metadata.

Before this commit, many operations where blocked when the cluster was read-only: Cluster Stats, Get Mappings, Get Snapshot, Get Index Settings, etc. Now those operations are allowed even when
the cluster or the index is read-only.

Related to elastic#8102, elastic#2833

Closes elastic#3703
Closes elastic#5855
Closes elastic#10521
Closes elastic#10522
@tlrx tlrx closed this as completed in adc0807 Apr 23, 2015
tlrx added a commit that referenced this issue Apr 23, 2015
@tlrx
Internal: Add METADATA_READ and METADATA_WRITE blocks
af79a2a 
This commit splits the current ClusterBlockLevel.METADATA into two disctins ClusterBlockLevel.METADATA_READ and ClusterBlockLevel.METADATA_WRITE blocks. It allows to make a distinction between
an operation that modifies the index or cluster metadata and an operation that does not change any metadata.
Before this commit, many operations where blocked when the cluster was read-only: Cluster Stats, Get Mappings, Get Snapshot, Get Index Settings, etc. Now those operations are allowed even when
the cluster or the index is read-only.

Related to #8102

Closes #3703
Closes #5855
Closes #10521
Closes #10522
Closes #2833
@clintongormley clintongormley added :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. and removed :Cluster labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlrx tlrx

Labels
>bug :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v1.6.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add METADATA_READ and METADATA_WRITE blocks tlrx/elasticsearch
3 participants
@clintongormley @tlrx @javanna