Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] auto_bucket annotation is missing the string type of third and fourth args #104646

Closed
dej611 opened this issue Jan 23, 2024 · 4 comments · Fixed by #111874
Closed

[ES|QL] auto_bucket annotation is missing the string type of third and fourth args #104646

dej611 opened this issue Jan 23, 2024 · 4 comments · Fixed by #111874
Assignees
@ivancea
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@dej611
Copy link
Contributor

dej611 commented Jan 23, 2024

Elasticsearch Version

8.13.0

Installed Plugins

No response

Java Version

bundled

OS Version

MacOS

Problem Description

In the auto_bucket annotation is missing the string type for the third and fourth arguments.
See the show functions output:

double|date auto_bucket(field:integer|long|double|date, buckets:integer, from:integer|long|double|date, to:integer|long|double|date)

Steps to Reproduce

show functions | where name == "auto_bucket"

Logs (if relevant)

No response
@dej611 dej611 added >bug needs:triage Requires assignment of a team area label labels Jan 23, 2024
@andreidan andreidan added :Analytics/ES|QL AKA ESQL and removed needs:triage Requires assignment of a team area label labels Jan 23, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 23, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@alex-spies
Copy link
Contributor

This might be superseded by #102756 in the future.

@fang-xing-esql fang-xing-esql mentioned this issue Jan 23, 2024
Merged
@fang-xing-esql
Copy link
Member

This might be superseded by #102756 in the future.

This is a good catch. I'm including the supported data types in this PR #104547.

@astefan
Copy link
Contributor

astefan commented Jul 2, 2024

@ivancea this might be the same issue as #105375

@bpintea bpintea mentioned this issue Aug 14, 2024
Merged
lkts pushed a commit to lkts/elasticsearch that referenced this issue Aug 20, 2024
@bpintea @lkts
ESQL: BUCKET: allow numerical spans as whole numbers (elastic#111874)
b368a84 
This laxes the check on numerical spans to allow them be specified as whole numbers. So far it was required that they be provided as a double.

This also expands the tests for date ranges to include string types.

Resolves elastic#109340, resolves elastic#104646, resolves elastic#105375.
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Sep 4, 2024
@bpintea @cbuescher
ESQL: BUCKET: allow numerical spans as whole numbers (elastic#111874)
646f9ef 
This laxes the check on numerical spans to allow them be specified as whole numbers. So far it was required that they be provided as a double.

This also expands the tests for date ranges to include string types.

Resolves elastic#109340, resolves elastic#104646, resolves elastic#105375.
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this issue Sep 5, 2024
@bpintea @davidkyle
ESQL: BUCKET: allow numerical spans as whole numbers (elastic#111874)
81da620 
This laxes the check on numerical spans to allow them be specified as whole numbers. So far it was required that they be provided as a double.

This also expands the tests for date ranges to include string types.

Resolves elastic#109340, resolves elastic#104646, resolves elastic#105375.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivancea ivancea

Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESQL: BUCKET: allow numerical spans as whole numbers bpintea/elasticsearch
7 participants
@astefan @dej611 @andreidan @ivancea @elasticsearchmachine @alex-spies @fang-xing-esql