-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] HeapAttackIT failing #102784
Labels
:Analytics/ES|QL
AKA ESQL
medium-risk
An open issue or test failure that is a medium risk to future releases
Team:QL (Deprecated)
Meta label for query languages team
>test-failure
Triaged test failures from CI
Comments
breskeby
added
:Analytics/EQL
EQL querying
>test-failure
Triaged test failures from CI
labels
Nov 29, 2023
Pinging @elastic/es-ql (Team:QL) |
elasticsearchmachine
added
the
Team:QL (Deprecated)
Meta label for query languages team
label
Nov 29, 2023
breskeby
changed the title
[CI] HeapAttackIT testSortByManyLongsTooMuchMemory failing
[CI] HeapAttackIT failing
Nov 29, 2023
@alex-spies or @dnhatn would you like this or should I dig? |
@nik9000 I can take this. |
dnhatn
added
medium-risk
An open issue or test failure that is a medium risk to future releases
:Analytics/ES|QL
AKA ESQL
and removed
blocker
:Analytics/EQL
EQL querying
labels
Nov 29, 2023
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
I think I have found the issue. We miss tracking memory in TopNOperator. I will work on the fix shortly. |
dnhatn
added a commit
that referenced
this issue
Dec 1, 2023
This commit addresses the issue of missing memory tracking for the BitSet in TopN.Row. Instead of introducing BreakingBitSet, we replace the BitSet with a smaller array of offsets in this PR. Nik suggested to remove that BitSet, but I haven't looked into that option yet. Closes #100640 Closes #102683 Closes #102790 Closes #102784
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this issue
Dec 1, 2023
This commit addresses the issue of missing memory tracking for the BitSet in TopN.Row. Instead of introducing BreakingBitSet, we replace the BitSet with a smaller array of offsets in this PR. Nik suggested to remove that BitSet, but I haven't looked into that option yet. Closes elastic#100640 Closes elastic#102683 Closes elastic#102790 Closes elastic#102784
elasticsearchmachine
pushed a commit
that referenced
this issue
Dec 1, 2023
This commit addresses the issue of missing memory tracking for the BitSet in TopN.Row. Instead of introducing BreakingBitSet, we replace the BitSet with a smaller array of offsets in this PR. Nik suggested to remove that BitSet, but I haven't looked into that option yet. Closes #100640 Closes #102683 Closes #102790 Closes #102784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
medium-risk
An open issue or test failure that is a medium risk to future releases
Team:QL (Deprecated)
Meta label for query languages team
>test-failure
Triaged test failures from CI
The HeapAttackIT test has started to fail on a daily basis since 22th of november
Build scan:
https://gradle-enterprise.elastic.co/s/h2qxzbqn5vq2m/tests/:x-pack:plugin:esql:qa:server:single-node:javaRestTest/org.elasticsearch.xpack.esql.qa.single_node.HeapAttackIT/testSortByManyLongsTooMuchMemory
Reproduction line:
Applicable branches:
main
Reproduces locally?:
Didn't try
Failure history:
https://es-delivery-stats.elastic.dev/app/dashboards#/view/dcec9e60-72ac-11ee-8f39-55975ded9e63?_g=(refreshInterval:(pause:!t,value:60000),time:(from:now-7d%2Fd,to:now))&_a=(controlGroupInput:(chainingSystem:HIERARCHICAL,controlStyle:twoLine,ignoreParentSettings:(ignoreFilters:!f,ignoreQuery:!f,ignoreTimerange:!f,ignoreValidations:!t),panels:('0c0c9cb8-ccd2-45c6-9b13-96bac4abc542':(explicitInput:(dataViewId:fbbdc689-be23-4b3d-8057-aa402e9ed0c5,enhancements:(),fieldName:task.keyword,grow:!t,id:'0c0c9cb8-ccd2-45c6-9b13-96bac4abc542',searchTechnique:wildcard,selectedOptions:!(),singleSelect:!t,title:'Gradle%20Task',width:medium),grow:!t,order:0,type:optionsListControl,width:small),'144933da-5c1b-4257-a969-7f43455a7901':(explicitInput:(dataViewId:fbbdc689-be23-4b3d-8057-aa402e9ed0c5,enhancements:(),fieldName:name.keyword,grow:!t,id:'144933da-5c1b-4257-a969-7f43455a7901',searchTechnique:wildcard,selectedOptions:!('testSortByManyLongsTooMuchMemory'),title:Test,width:medium),grow:!t,order:2,type:optionsListControl,width:medium),'4e6ad9d6-6fdc-4fcc-bf1a-aa6ca79e0850':(explicitInput:(dataViewId:fbbdc689-be23-4b3d-8057-aa402e9ed0c5,enhancements:(),fieldName:className.keyword,grow:!t,id:'4e6ad9d6-6fdc-4fcc-bf1a-aa6ca79e0850',searchTechnique:wildcard,selectedOptions:!('org.elasticsearch.xpack.esql.qa.single_node.HeapAttackIT'),title:Suite,width:medium),grow:!t,order:1,type:optionsListControl,width:medium))))
Failure excerpt:
The text was updated successfully, but these errors were encountered: