Skip to content

Commit

Permalink
Fix SearchCancellationIT failures (#101777) (#102009)
Browse files Browse the repository at this point in the history
We need at least two data nodes in this test, otherwise we are not guaranteed to get two concurrently executing shard query requests because max concurrency could be 1.

closes #101739 #99929
  • Loading branch information
original-brownbear authored Nov 10, 2023
1 parent 6784f54 commit df73595
Showing 1 changed file with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import org.elasticsearch.tasks.TaskCancelledException;
import org.elasticsearch.test.AbstractSearchCancellationTestCase;
import org.elasticsearch.test.ESIntegTestCase;
import org.elasticsearch.test.junit.annotations.TestIssueLogging;
import org.elasticsearch.transport.TransportService;

import java.util.ArrayList;
Expand Down Expand Up @@ -231,11 +230,10 @@ public void testCancelMultiSearch() throws Exception {
}
}

@TestIssueLogging(
value = "org.elasticsearch.action.search:TRACE,org.elasticsearch.search:TRACE," + "org.elasticsearch.tasks:TRACE",
issueUrl = "https://github.com/elastic/elasticsearch/issues/99929"
)
public void testCancelFailedSearchWhenPartialResultDisallowed() throws Exception {
// Have at least two nodes so that we have parallel execution of two request guaranteed even if max concurrent requests per node
// are limited to 1
internalCluster().ensureAtLeastNumDataNodes(2);
int numberOfShards = between(2, 5);
createIndex("test", numberOfShards, 0);
indexTestData();
Expand Down

0 comments on commit df73595

Please sign in to comment.