Address Luca's feedback 2

elastic · Aug 12, 2022 · dbf2022 · dbf2022
1 parent 1ee4270
commit dbf2022
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/server/src/main/java/org/elasticsearch/index/mapper/DocumentParserContext.java b/server/src/main/java/org/elasticsearch/index/mapper/DocumentParserContext.java
@@ -277,8 +277,11 @@ final ObjectMapper getDynamicObjectMapper(String name) {
 
     /**
      * Add a new runtime field dynamically created while parsing.
+     * We use the same set for both new indexed and new runtime fields,
+     * because for dynamic mappings, a new field can be either mapped
+     * as runtime or indexed, but never both.
      */
-    public final void addDynamicRuntimeField(RuntimeField runtimeField) {
+    final void addDynamicRuntimeField(RuntimeField runtimeField) {
         if (newFieldsSeen.add(runtimeField.name())) {
             mappingLookup.checkFieldLimit(indexSettings().getMappingTotalFieldsLimit(), newFieldsSeen.size());
         }