[TEST] Fix GetUserPrivilegesResponse#Indices(StreamInput) constr

Closes #34631
elastic · Oct 30, 2018 · bb2f02a · bb2f02a
1 parent ea62c16
commit bb2f02a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/...ain/java/org/elasticsearch/xpack/core/security/action/user/GetUserPrivilegesResponse.java b/...ain/java/org/elasticsearch/xpack/core/security/action/user/GetUserPrivilegesResponse.java
@@ -132,8 +132,9 @@ public Indices(Collection<String> indices, Collection<String> privileges,
         }
 
         public Indices(StreamInput in) throws IOException {
-            indices = Collections.unmodifiableSet(in.readSet(StreamInput::readString));
-            privileges = Collections.unmodifiableSet(in.readSet(StreamInput::readString));
+            // The use of TreeSet is to provide a consistent order that can be relied upon in tests
+            indices = Collections.unmodifiableSet(new TreeSet<>(in.readSet(StreamInput::readString)));
+            privileges = Collections.unmodifiableSet(new TreeSet<>(in.readSet(StreamInput::readString)));
             fieldSecurity = Collections.unmodifiableSet(in.readSet(input -> {
                 final String[] grant = input.readOptionalStringArray();
                 final String[] exclude = input.readOptionalStringArray();