Skip to content

Commit

Permalink
add comment about node setting
Browse files Browse the repository at this point in the history
  • Loading branch information
ywelsch committed May 22, 2018
1 parent 12110b9 commit ba94bdd
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,10 @@ public Settings additionalSettings() {

return super.additionalSettings();
} else {
// Unfortunately we cannot simply disallow any value for xpackInstalledNodeAttrSetting, because the
// internal cluster integration test framework will restart nodes with settings copied from the node
// immediately before it was stopped. The best we can do is reject inconsistencies.
// TODO: fix the test framework not to copy derived node settings upon restart.
if (settings.get(xpackInstalledNodeAttrSetting) != null &&
settings.get(xpackInstalledNodeAttrSetting).equals("true") == false) {
throw new IllegalArgumentException("Conflicting setting [" + xpackInstalledNodeAttrSetting + "]");
Expand Down

0 comments on commit ba94bdd

Please sign in to comment.