Relax data path deprecations from critical to warn (#85952) (#85963)

The deprecations for index and shared data paths were defined at critical level, but these are not removed in 8.0. This commit relaxes these deprecation messages so they are just warnings. relates #85695
elastic · Apr 18, 2022 · b847e5d · b847e5d
1 parent a1935d2
commit b847e5d
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/docs/changelog/85952.yaml b/docs/changelog/85952.yaml
@@ -0,0 +1,5 @@
+pr: 85952
+summary: Relax data path deprecations from critical to warn
+area: Infra/Core
+type: bug
+issues: []
diff --git a/...deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecks.java b/...deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecks.java
@@ -76,7 +76,7 @@ static DeprecationIssue checkIndexDataPath(IndexMetadata indexMetadata) {
             final String url = "https://www.elastic.co/guide/en/elasticsearch/reference/7.13/"
                 + "breaking-changes-7.13.html#deprecate-shared-data-path-setting";
             final String details = "Found index data path configured. Discontinue use of this setting.";
-            return new DeprecationIssue(DeprecationIssue.Level.CRITICAL, message, url, details, false, null);
+            return new DeprecationIssue(DeprecationIssue.Level.WARNING, message, url, details, false, null);
         }
         return null;
     }

diff --git a/.../deprecation/src/main/java/org/elasticsearch/xpack/deprecation/NodeDeprecationChecks.java b/.../deprecation/src/main/java/org/elasticsearch/xpack/deprecation/NodeDeprecationChecks.java
@@ -129,7 +129,7 @@ static DeprecationIssue checkSharedDataPathSetting(
             final String url = "https://www.elastic.co/guide/en/elasticsearch/reference/7.13/"
                 + "breaking-changes-7.13.html#deprecate-shared-data-path-setting";
             final String details = "Found shared data path configured. Discontinue use of this setting.";
-            return new DeprecationIssue(DeprecationIssue.Level.CRITICAL, message, url, details, false, null);
+            return new DeprecationIssue(DeprecationIssue.Level.WARNING, message, url, details, false, null);
         }
         return null;
     }

diff --git a/...cation/src/test/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecksTests.java b/...cation/src/test/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecksTests.java
@@ -93,7 +93,7 @@ public void testIndexDataPathSetting() {
             issues,
             contains(
                 new DeprecationIssue(
-                    DeprecationIssue.Level.CRITICAL,
+                    DeprecationIssue.Level.WARNING,
                     "setting [index.data_path] is deprecated and will be removed in a future version",
                     expectedUrl,
                     "Found index data path configured. Discontinue use of this setting.",

diff --git a/...ecation/src/test/java/org/elasticsearch/xpack/deprecation/NodeDeprecationChecksTests.java b/...ecation/src/test/java/org/elasticsearch/xpack/deprecation/NodeDeprecationChecksTests.java
@@ -91,7 +91,7 @@ public void testSharedDataPathSetting() {
             issues,
             contains(
                 new DeprecationIssue(
-                    DeprecationIssue.Level.CRITICAL,
+                    DeprecationIssue.Level.WARNING,
                     "setting [path.shared_data] is deprecated and will be removed in a future version",
                     expectedUrl,
                     "Found shared data path configured. Discontinue use of this setting.",