-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
QL: Introduce common analyzer base class
Extract the analyzer base classes into a common project similar to the Optimizer ones. Extract AddMissingEqualsOnBoolFields a common rule to be used across Close #63695
- Loading branch information
Showing
4 changed files
with
116 additions
and
92 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
x-pack/plugin/ql/src/main/java/org/elasticsearch/xpack/ql/analyzer/AnalyzerRules.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| package org.elasticsearch.xpack.ql.analyzer; | ||
|
|
||
| import org.elasticsearch.xpack.ql.expression.Expression; | ||
| import org.elasticsearch.xpack.ql.expression.FieldAttribute; | ||
| import org.elasticsearch.xpack.ql.expression.Literal; | ||
| import org.elasticsearch.xpack.ql.expression.predicate.logical.BinaryLogic; | ||
| import org.elasticsearch.xpack.ql.expression.predicate.operator.comparison.Equals; | ||
| import org.elasticsearch.xpack.ql.plan.logical.Filter; | ||
| import org.elasticsearch.xpack.ql.plan.logical.LogicalPlan; | ||
| import org.elasticsearch.xpack.ql.rule.Rule; | ||
|
|
||
| import static java.util.Arrays.asList; | ||
|
|
||
| public final class AnalyzerRules { | ||
|
|
||
| public static class AddMissingEqualsToBoolField extends AnalyzerRule<Filter> { | ||
|
|
||
| @Override | ||
| protected LogicalPlan rule(Filter filter) { | ||
| // check the condition itself | ||
| Expression condition = replaceRawBoolFieldWithEquals(filter.condition()); | ||
| // otherwise look for binary logic | ||
| if (condition == filter.condition()) { | ||
| condition = condition.transformUp(b -> | ||
| b.replaceChildren(asList(replaceRawBoolFieldWithEquals(b.left()), replaceRawBoolFieldWithEquals(b.right()))) | ||
| , BinaryLogic.class); | ||
| } | ||
|
|
||
| if (condition != filter.condition()) { | ||
| filter = new Filter(filter.source(), filter.child(), condition); | ||
| } | ||
| return filter; | ||
| } | ||
|
|
||
| private Expression replaceRawBoolFieldWithEquals(Expression e) { | ||
| if (e instanceof FieldAttribute) { | ||
| e = new Equals(e.source(), e, Literal.of(e, Boolean.TRUE)); | ||
| } | ||
| return e; | ||
| } | ||
|
|
||
| @Override | ||
| protected boolean skipResolved() { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| public static abstract class AnalyzerRule<SubPlan extends LogicalPlan> extends Rule<SubPlan, LogicalPlan> { | ||
|
|
||
| // transformUp (post-order) - that is first children and then the node | ||
| // but with a twist; only if the tree is not resolved or analyzed | ||
| @Override | ||
| public final LogicalPlan apply(LogicalPlan plan) { | ||
| return plan.transformUp(t -> t.analyzed() || skipResolved() && t.resolved() ? t : rule(t), typeToken()); | ||
| } | ||
|
|
||
| @Override | ||
| protected abstract LogicalPlan rule(SubPlan plan); | ||
|
|
||
| protected boolean skipResolved() { | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| public abstract static class BaseAnalyzerRule extends AnalyzerRule<LogicalPlan> { | ||
|
|
||
| @Override | ||
| protected LogicalPlan rule(LogicalPlan plan) { | ||
| if (plan.childrenResolved() == false) { | ||
| return plan; | ||
| } | ||
| return doRule(plan); | ||
| } | ||
|
|
||
| protected abstract LogicalPlan doRule(LogicalPlan plan); | ||
| } | ||
| } |
Oops, something went wrong.