NORELEASE for getWriteableName in aggregations base class

elastic · Apr 14, 2016 · 9080f51 · 9080f51
1 parent f095e64
commit 9080f51
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/core/src/main/java/org/elasticsearch/search/aggregations/AggregatorBuilder.java b/core/src/main/java/org/elasticsearch/search/aggregations/AggregatorBuilder.java
@@ -190,6 +190,7 @@ public final XContentBuilder toXContent(XContentBuilder builder, Params params)
 
     @Override
     public String getWriteableName() {
+        // NORELEASE remove this before 5.0.0GA - all builders will implement this method on their own.
         return type.stream().toUtf8();
     }
 

diff --git a/...va/org/elasticsearch/search/aggregations/bucket/histogram/HistogramAggregatorBuilder.java b/...va/org/elasticsearch/search/aggregations/bucket/histogram/HistogramAggregatorBuilder.java
@@ -51,4 +51,8 @@ protected HistogramAggregatorFactory innerBuild(AggregationContext context, Valu
                 parent, subFactoriesBuilder, metaData);
     }
 
+    @Override
+    public String getWriteableName() {
+        return NAME;
+    }
 }