Skip to content

Commit

Permalink
[ML] Use correct writable name for model assignment metadata in mixed…
Browse files Browse the repository at this point in the history
… cluster (#100886)

Older nodes will fail if they do not recognise the named writable
  • Loading branch information
davidkyle authored Oct 16, 2023
1 parent d01c61f commit 83abb37
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions docs/changelog/100886.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 100886
summary: Use the correct writable name for model assignment metadata in mixed version clusters. Prevents a node failure due to IllegalArgumentException Unknown NamedWriteable [trained_model_assignment]
area: Machine Learning
type: bug
issues: []
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,8 @@ private TrainedModeAssignmentDiff(final StreamInput in, String writeableName) th
@Override
public Metadata.Custom apply(Metadata.Custom part) {
return new TrainedModelAssignmentMetadata(
new TreeMap<>(modelRoutingEntries.apply(((TrainedModelAssignmentMetadata) part).deploymentRoutingEntries))
new TreeMap<>(modelRoutingEntries.apply(((TrainedModelAssignmentMetadata) part).deploymentRoutingEntries)),
writeableName
);
}

Expand Down

0 comments on commit 83abb37

Please sign in to comment.