Skip to content

Commit

Permalink
Reenable testWhenUserLimitedByOnlyAliasOfIndexCanWriteToIndexWhichWas…
Browse files Browse the repository at this point in the history
…RolledoverByILMPolicy (#51768) (#51801)

We suspect the flakiness could’ve come from the fact that the rollover
step used to create the new index and roll the write alias to the new
index in separate cluster state updates. So the assertion that the
rolled index exists could’ve passed in the test but, before the
alias was rolled over to the new index, the subsequent write we execute
in the test (namely
`indexDocs("test_user", "x-pack-test-password", "foo_alias", 1)`)
would’ve sent the new document to the source index (ie. foo-logs-000001)

This would see the source index containing 3 documents and the rolled
index (foo-logs-000002) 0 documents.

However, we fixed this and the rollover step executes the “create index
and roll alias” in one single cluster update, so this situation should
not occur anymore.

(cherry picked from commit 834261c)
Signed-off-by: Andrei Dan <[email protected]>
  • Loading branch information
andreidan authored Feb 3, 2020
1 parent d5d8fb2 commit 8138805
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,7 @@ public void testCanViewExplainOnUnmanagedIndex() throws Exception {
* Tests when the user is limited by alias of an index is able to write to index
* which was rolled over by an ILM policy.
*/
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/41440")
public void testWhenUserLimitedByOnlyAliasOfIndexCanWriteToIndexWhichWasRolledoverByILMPolicy()
throws Exception {
public void testWhenUserLimitedByOnlyAliasOfIndexCanWriteToIndexWhichWasRolledoverByILMPolicy() throws Exception {
/*
* Setup:
* - ILM policy to rollover index when max docs condition is met
Expand Down

0 comments on commit 8138805

Please sign in to comment.