Improving logging to troubelshoot pipeline metrics problem (#91439)

elastic · Nov 10, 2022 · 627b942 · 627b942
1 parent 448d288
commit 627b942
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/server/src/main/java/org/elasticsearch/ingest/CompoundProcessor.java b/server/src/main/java/org/elasticsearch/ingest/CompoundProcessor.java
@@ -210,7 +210,7 @@ void innerExecute(int currentProcessor, IngestDocument ingestDocument, final BiC
         try {
             finalProcessor.execute(ingestDocument, (result, e) -> {
                 if (listenerHasBeenCalled.getAndSet(true)) {
-                    logger.warn("A listener was unexpectedly called more than once", new RuntimeException());
+                    logger.warn("A listener was unexpectedly called more than once", new RuntimeException(e));
                     assert false : "A listener was unexpectedly called more than once";
                 } else {
                     long ingestTimeInNanos = relativeTimeProvider.getAsLong() - startTimeInNanos;
@@ -230,7 +230,7 @@ void innerExecute(int currentProcessor, IngestDocument ingestDocument, final BiC
         } catch (Exception e) {
             long ingestTimeInNanos = relativeTimeProvider.getAsLong() - startTimeInNanos;
             if (postIngestHasBeenCalled.get()) {
-                logger.warn("Preventing postIngest from being called more than once", new RuntimeException());
+                logger.warn("Preventing postIngest from being called more than once", e);
                 assert false : "Attempt to call postIngest more than once";
             } else {
                 finalMetric.postIngest(ingestTimeInNanos);

diff --git a/server/src/main/java/org/elasticsearch/ingest/ConditionalProcessor.java b/server/src/main/java/org/elasticsearch/ingest/ConditionalProcessor.java
@@ -135,7 +135,7 @@ public void execute(IngestDocument ingestDocument, BiConsumer<IngestDocument, Ex
             metric.preIngest();
             processor.execute(ingestDocument, (result, e) -> {
                 if (listenerHasBeenCalled.getAndSet(true)) {
-                    logger.warn("A listener was unexpectedly called more than once", new RuntimeException());
+                    logger.warn("A listener was unexpectedly called more than once", new RuntimeException(e));
                     assert false : "A listener was unexpectedly called more than once";
                 } else {
                     long ingestTimeInNanos = relativeTimeProvider.getAsLong() - startTimeInNanos;

diff --git a/server/src/main/java/org/elasticsearch/ingest/IngestService.java b/server/src/main/java/org/elasticsearch/ingest/IngestService.java
@@ -913,7 +913,7 @@ private void innerExecute(
         final AtomicBoolean listenerHasBeenCalled = new AtomicBoolean(false);
         ingestDocument.executePipeline(pipeline, (result, e) -> {
             if (listenerHasBeenCalled.getAndSet(true)) {
-                logger.warn("A listener was unexpectedly called more than once", new RuntimeException());
+                logger.warn("A listener was unexpectedly called more than once", new RuntimeException(e));
                 assert false : "A listener was unexpectedly called more than once";
             } else {
                 long ingestTimeInNanos = System.nanoTime() - startTimeInNanos;

diff --git a/server/src/main/java/org/elasticsearch/ingest/Pipeline.java b/server/src/main/java/org/elasticsearch/ingest/Pipeline.java
@@ -123,7 +123,7 @@ public void execute(IngestDocument ingestDocument, BiConsumer<IngestDocument, Ex
         metrics.preIngest();
         compoundProcessor.execute(ingestDocument, (result, e) -> {
             if (listenerHasBeenCalled.getAndSet(true)) {
-                logger.warn("A listener was unexpectedly called more than once", new RuntimeException());
+                logger.warn("A listener was unexpectedly called more than once", new RuntimeException(e));
                 assert false : "A listener was unexpectedly called more than once";
             } else {
                 long ingestTimeInNanos = relativeTimeProvider.getAsLong() - startTimeInNanos;