Skip to content

Commit

Permalink
Avoid uid creation in ParsedDocument (#27241)
Browse files Browse the repository at this point in the history
The uid bytes (as the type#id) were needlessly being created even though
they are no longer needed after the move to single type per index. This
commit avoids creating these when parsed documents are constructed.

Relates #27241
  • Loading branch information
mfussenegger authored and jasontedor committed Nov 3, 2017
1 parent dcb2cf4 commit 4fa5fac
Showing 1 changed file with 1 addition and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
package org.elasticsearch.index.mapper;

import org.apache.lucene.document.Field;
import org.apache.lucene.util.BytesRef;
import org.elasticsearch.common.bytes.BytesReference;
import org.elasticsearch.common.xcontent.XContentType;
import org.elasticsearch.index.mapper.ParseContext.Document;
Expand All @@ -35,7 +34,6 @@ public class ParsedDocument {
private final Field version;

private final String id, type;
private final BytesRef uid;
private final SeqNoFieldMapper.SequenceIDFields seqID;

private final String routing;
Expand All @@ -62,7 +60,6 @@ public ParsedDocument(Field version,
this.seqID = seqID;
this.id = id;
this.type = type;
this.uid = Uid.createUidAsBytes(type, id);
this.routing = routing;
this.documents = documents;
this.source = source;
Expand Down Expand Up @@ -140,9 +137,7 @@ public void addDynamicMappingsUpdate(Mapping update) {

@Override
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("Document ").append("uid[").append(uid).append("] doc [").append(documents).append("]");
return sb.toString();
return "Document uid[" + Uid.createUidAsBytes(type, id) + "] doc [" + documents + ']';
}

}

0 comments on commit 4fa5fac

Please sign in to comment.