Skip to content

Commit

Permalink
Omit translog bwc test before 6.3.0 with default distro (#57266)
Browse files Browse the repository at this point in the history
The new translog bwc test checks a corruption case before 6.3.0.
However, it needs to restart the old node to reproduce, which does not
currently work given how testclusters works when plugins are installed.
As a workaround, this commit omits creating bwc tests before 6.3.0 only
when the default distribution is used.

fixes #57252
  • Loading branch information
rjernst committed May 28, 2020
1 parent f6b9a99 commit 46bfbae
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions qa/translog-policy/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,14 @@ apply plugin: 'elasticsearch.testclusters'
apply plugin: 'elasticsearch.standalone-test'
apply from : "$rootDir/gradle/bwc-test.gradle"

boolean isDefaultDistro = System.getProperty('tests.distribution', 'oss') == 'default'
for (Version bwcVersion : BuildParams.bwcVersions.indexCompatible) {
if (bwcVersion.before('6.3.0') && isDefaultDistro) {
// explicitly running restart on the current node does not work in step 2
// below when plugins are installed, wihch is the case for x-pack as a plugin
// prior to 6.3.0
continue
}
String baseName = "v${bwcVersion}"

testClusters {
Expand Down

0 comments on commit 46bfbae

Please sign in to comment.