Skip to content

Commit

Permalink
Fix bit vector tests (#110521) (#110525)
Browse files Browse the repository at this point in the history
Bit vector tests were failing in cases where an index has more than 1 shards.
For error cases when we expected a failure of the whole request, shards
with empty documents returned success and the whoel request unexpectedly returned 200.

Ensuring that index contains only 1 shard fixes these failures.

Closes #110290, #110291
  • Loading branch information
mayya-sharipova authored Jul 5, 2024
1 parent 077b94e commit 3f2c81e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ setup:
indices.create:
index: test-index
body:
settings:
number_of_shards: 1
mappings:
properties:
vector:
Expand Down Expand Up @@ -107,7 +109,6 @@ setup:
headers:
Content-Type: application/json
search:
rest_total_hits_as_int: true
body:
query:
script_score:
Expand Down Expand Up @@ -138,7 +139,6 @@ setup:
headers:
Content-Type: application/json
search:
rest_total_hits_as_int: true
body:
query:
script_score:
Expand All @@ -152,7 +152,6 @@ setup:
headers:
Content-Type: application/json
search:
rest_total_hits_as_int: true
body:
query:
script_score:
Expand All @@ -167,7 +166,6 @@ setup:
headers:
Content-Type: application/json
search:
rest_total_hits_as_int: true
body:
query:
script_score:
Expand Down
6 changes: 0 additions & 6 deletions muted-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,6 @@ tests:
- class: org.elasticsearch.compute.lucene.ValueSourceReaderTypeConversionTests
method: testLoadAll
issue: https://github.com/elastic/elasticsearch/issues/110244
- class: org.elasticsearch.painless.LangPainlessClientYamlTestSuiteIT
method: test {yaml=painless/146_dense_vector_bit_basic/Cosine Similarity is not supported}
issue: https://github.com/elastic/elasticsearch/issues/110290
- class: org.elasticsearch.painless.LangPainlessClientYamlTestSuiteIT
method: test {yaml=painless/146_dense_vector_bit_basic/Dot Product is not supported}
issue: https://github.com/elastic/elasticsearch/issues/110291
- class: org.elasticsearch.action.search.SearchProgressActionListenerIT
method: testSearchProgressWithQuery
issue: https://github.com/elastic/elasticsearch/issues/109867
Expand Down

0 comments on commit 3f2c81e

Please sign in to comment.