Simplify FrozenEngine#getReader (#39539)

We really don’t need a try/finally in this method.
elastic · Mar 6, 2019 · 3591da6 · 3591da6
1 parent 7da62d3
commit 3591da6
Showing 1 changed file with 4 additions and 13 deletions.
diff --git a/x-pack/plugin/core/src/main/java/org/elasticsearch/index/engine/FrozenEngine.java b/x-pack/plugin/core/src/main/java/org/elasticsearch/index/engine/FrozenEngine.java
@@ -186,20 +186,11 @@ private synchronized DirectoryReader getOrOpenReader() throws IOException {
     }
 
     @SuppressForbidden(reason = "we manage references explicitly here")
-    private synchronized DirectoryReader getReader() throws IOException {
-        DirectoryReader reader = null;
-        boolean success = false;
-        try {
-            if (lastOpenedReader != null && lastOpenedReader.tryIncRef()) {
-                reader = lastOpenedReader;
-            }
-            success = true;
-            return reader;
-        } finally {
-            if (success == false) {
-                IOUtils.close(reader);
-            }
+    private synchronized DirectoryReader getReader() {
+        if (lastOpenedReader != null && lastOpenedReader.tryIncRef()) {
+            return lastOpenedReader;
         }
+        return null;
     }
 
     @Override