Fix Stack Overflow in UnassignedInfo in Corner Case (#76480) (#76546)

We kept wrapping the collection over and over again which in extreme corner cases could lead to a SOE. Closes #76490 Co-authored-by: hanbj <[email protected]>
elastic · Aug 16, 2021 · 2f556ef · 2f556ef
1 parent 57092cc
commit 2f556ef
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/server/src/main/java/org/elasticsearch/cluster/routing/UnassignedInfo.java b/server/src/main/java/org/elasticsearch/cluster/routing/UnassignedInfo.java
@@ -242,7 +242,7 @@ public UnassignedInfo(Reason reason, @Nullable String message, @Nullable Excepti
         this.failure = failure;
         this.failedAllocations = failedAllocations;
         this.lastAllocationStatus = Objects.requireNonNull(lastAllocationStatus);
-        this.failedNodeIds = Collections.unmodifiableSet(failedNodeIds);
+        this.failedNodeIds = org.elasticsearch.core.Set.copyOf(failedNodeIds);
         assert (failedAllocations > 0) == (reason == Reason.ALLOCATION_FAILED) :
             "failedAllocations: " + failedAllocations + " for reason " + reason;
         assert (message == null && failure != null) == false : "provide a message if a failure exception is provided";