Skip to content

Commit

Permalink
Fix testWaitForClusterStateToBeAppliedOnSourceNode (#100240)
Browse files Browse the repository at this point in the history
The tripping assertion here is just bogus, it's entirely possible that
the replica node has sent (and the primary node has received) the
`START_RECOVERY` message before the replica notifies its cluster state
listener waiting to see the new routing table.

Closes #100222
  • Loading branch information
DaveCTurner authored Oct 4, 2023
1 parent bb5ed98 commit 2c0834b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1623,7 +1623,6 @@ public void testReservesBytesDuringPeerRecoveryPhaseOne() throws Exception {
);
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/100222")
public void testWaitForClusterStateToBeAppliedOnSourceNode() throws Exception {
internalCluster().startMasterOnlyNode();
final var primaryNode = internalCluster().startDataOnlyNode();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ public void onStartRecovery() {
}

public void delayUntilRecoveryStart(SubscribableListener<Void> listener) {
ESTestCase.assertFalse(startRecoveryListener.isDone());
startRecoveryListener.addListener(listener);
}
}

0 comments on commit 2c0834b

Please sign in to comment.