-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prevent field API NPEs from token_count fields inside nested (#69068)
Currently when a `token_count` field is defined inside a nested field, we get an NPE because the underlying DocValueFetcher needs its formattedDocValues to be loaded and the SourceLookup it sees needs to have a valid docId other than -1. This change fixes those issues so the whole fields request doesn't error. However this change doesn't solve the missing support for doc values lookup under nested fields described in 68983. Fortunately `token_count` seems to be the only mapping type currently affected. Relates to #68983
- Loading branch information
Christoph Büscher
committed
Feb 19, 2021
1 parent
b3d3430
commit 0fec6e4
Showing
2 changed files
with
43 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters