Skip to content

Commit

Permalink
Restore assertion on discount overlaps in SimilarityTests
Browse files Browse the repository at this point in the history
This assertion was commented out as the getDiscountOverlaps getter was
missing from LegacyBm25Similarity. That has been fixed in lucene.
  • Loading branch information
javanna committed Jan 15, 2019
1 parent 1a1dbf7 commit 0b396a0
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ public void testResolveSimilaritiesFromMapping_bm25() throws IOException {
LegacyBM25Similarity similarity = (LegacyBM25Similarity) mapperService.fullName("field1").similarity().get();
assertThat(similarity.getK1(), equalTo(2.0f));
assertThat(similarity.getB(), equalTo(0.5f));
// TODO: re-enable when we switch back to BM25Similarity
// assertThat(similarity.getDiscountOverlaps(), equalTo(false));
assertThat(similarity.getDiscountOverlaps(), equalTo(false));
}

public void testResolveSimilaritiesFromMapping_boolean() throws IOException {
Expand Down

0 comments on commit 0b396a0

Please sign in to comment.