Enable DATE conversions #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change to METATYPE_DATE_TIME after ES/SQL's timestamp data type renaming to DATETIME
- rename function that parses date/time/timestamp
- add a page counter to track how many pages have been fetched from ES
- current day has been added
- allow the new DATE type be converted to timestamp and date structs.
bpintea
added a commit
that referenced
this pull request
Feb 20, 2019
* rename meta type for date/time/timestamp - change to METATYPE_DATE_TIME after ES/SQL's timestamp data type renaming to DATETIME * s/parse_datetime/parse_date_time_ts/ - rename function that parses date/time/timestamp * add a resultset / page counter - add a page counter to track how many pages have been fetched from ES * update advertized supported scalars - current day has been added * enable DATE conversion - allow the new DATE type be converted to timestamp and date structs. (cherry picked from commit 029d794)
bpintea
added
>feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the DATE data type conversion.
It also updates the advertised available standard scalars and adds a fetched pages counter.