[Backport 8.x] Add IP Location APIs #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Add IP Location APIs * Rename these files * Reword this description * Handle ipinfo in addition to maxmind * A slightly more faithful alternative approach * Remove accidentally-added line * A more-correct implementation of the second approach * Another approach using @Variants container * Fix IP location APIs * Update specification/ingest/get_ip_location_database/GetIpLocationDatabaseResponse.ts Co-authored-by: Laura Trotta <[email protected]> * Update specification/ingest/get_ip_location_database/GetIpLocationDatabaseResponse.ts Co-authored-by: Quentin Pradet <[email protected]> * Fix an import and then make generate, etc * Remove unused import --------- Co-authored-by: Joe Gallo <[email protected]> Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit dae081f)
pquentin
approved these changes
Dec 18, 2024
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport dae081f from #3107.