Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark data lifecycle APIs as stable #3109

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Nov 8, 2024

As noticed in #3019, but extracting it into its own pull request is easier until the IP location APIs are merged. This also include an unrelated fix to the same APIs that I submitted to Elasticsearch: elastic/elasticsearch#116292

@pquentin pquentin merged commit 17693a6 into main Nov 8, 2024
8 checks passed
@pquentin pquentin deleted the data-lifecycle-stability branch November 8, 2024 11:05
Copy link
Contributor

github-actions bot commented Nov 8, 2024

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3109-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 17693a6ccd679cb943c952838a700c673b13b9ad
# Push it to GitHub
git push --set-upstream origin backport-3109-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3109-to-8.x.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

The backport to 8.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3109-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 17693a6ccd679cb943c952838a700c673b13b9ad
# Push it to GitHub
git push --set-upstream origin backport-3109-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16

Then, create a pull request where the base branch is 8.16 and the compare/head branch is backport-3109-to-8.16.

pquentin added a commit that referenced this pull request Nov 12, 2024
pquentin added a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants