Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix knn_search deprecation message #3103

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Nov 6, 2024

The message is defined in the rest-api-spec, but schema.json uses the value from the specification request, so I copied it from there:

"description": "The kNN search API has been replaced by the `knn` option in the search API."

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
knn_search 🟢 4/4 4/4

You can validate this API yourself by using the make validate target.

@pquentin pquentin merged commit 48e2d9d into main Nov 6, 2024
8 checks passed
@pquentin pquentin deleted the knn-search-deprecation-message branch November 6, 2024 12:33
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants