-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix most pipeline API errors #2854
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
In |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Thanks Laura! Removing Please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was done purely looking at the YAML test errors. The Put pipeline API has one error left: the Redact processor is still missing.
Note that even when we hit 100%, the work on ingest pipelines won't be over. Not only there are number of pipelines still missing (tracked in #2231), but we have not added all ingest modules to YAML tests.