Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing details in the create transform API #1067

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Adds missing details in the create transform API #1067

merged 4 commits into from
Nov 30, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 25, 2021 •
edited
Loading

Relates to elastic/elasticsearch#79003, elastic/elasticsearch#56007, and elastic/elasticsearch#76609

This PR:

  • Adds align_checkpoints and _meta to the create transform API specification.
  • Removes the discontinued max_page_search_size from the pivot configuration.
  • Adds more descriptions based on the documentation

@lcawl lcawl requested a review from przemekwitek November 25, 2021 22:20
@lcawl lcawl requested a review from hendrikmuhs November 29, 2021 16:18
przemekwitek
przemekwitek approved these changes Nov 30, 2021
View reviewed changes
Copy link

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

output/schema/schema.json Show resolved Hide resolved
output/schema/schema.json Show resolved Hide resolved
@lcawl lcawl merged commit ca49817 into main Nov 30, 2021
github-actions bot pushed a commit that referenced this pull request Nov 30, 2021
@lcawl @github-actions
Adds missing details in the create transform API (#1067)
be43df4
@github-actions github-actions bot mentioned this pull request Nov 30, 2021
Merged
@lcawl lcawl deleted the create-transform branch November 30, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemekwitek przemekwitek przemekwitek approved these changes

@hendrikmuhs hendrikmuhs Awaiting requested review from hendrikmuhs

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @przemekwitek