-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ML infer trained model deployment API #1060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Here's a couple comments:
specification/ml/infer_trained_model_deployment/MlInferTrainedModelDeploymentRequest.ts
Outdated
Show resolved
Hide resolved
specification/ml/infer_trained_model_deployment/MlInferTrainedModelDeploymentResponse.ts
Show resolved
Hide resolved
specification/ml/infer_trained_model_deployment/MlInferTrainedModelDeploymentResponse.ts
Outdated
Show resolved
Hide resolved
specification/ml/infer_trained_model_deployment/MlInferTrainedModelDeploymentResponse.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
specification/ml/infer_trained_model_deployment/MlInferTrainedModelDeploymentResponse.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question and one comment, otherwise this LGTM! 🎉
specification/ml/infer_trained_model_deployment/MlInferTrainedModelDeploymentRequest.ts
Outdated
Show resolved
Hide resolved
…ModelDeploymentResponse.ts Co-authored-by: David Kyle <[email protected]>
…ModelDeploymentResponse.ts
Relates to elastic/elasticsearch#73660
This PR adds a specification for the ML infer trained model deployment API per https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/ml.infer_trained_model_deployment.json
NOTE: I have omitted the security details for now, since they're missing from the documentation but we'll want to fix that in both places.