Ensure a custom User-Agent header is not overwritten #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzakral
suggested changes
Aug 12, 2019
elasticsearch/transport.py
Outdated
| @@ -339,7 +339,8 @@ def perform_request(self, method, url, headers=None, params=None, body=None): | |||
|
|
|||
| if headers is None: | |||
| headers = {} | |||
| headers["user-agent"] = "elasticsearch-py/%s (Python %s)" % (__versionstr__, python_version()) | |||
| if "user-agent" not in headers: | |||
| headers["user-agent"] = "elasticsearch-py/%s (Python %s)" % (__versionstr__, python_version()) | |||
There was a problem hiding this comment.
Could we perhaps not do this at every request? I think this should follow the same exact logic as setting content-type at https://github.com/elastic/elasticsearch-py/blob/master/elasticsearch/connection/http_urllib3.py#L129 - done only once when instantiating the client and kept there as the default. Also all the headers will then be set in a single place.
honzakral
approved these changes
Aug 12, 2019
|
my pleasure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is an enhancement to the comment of PR#991 and ensures that a custom
user-agentheader is not overwritten with the default value.